Skip to content

Commit 28eeec7

Browse files
author
Michael Bridgen
committed
Clear up a couple of things in comments
1 parent c45a104 commit 28eeec7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/com/rabbitmq/client/impl/AMQConnection.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,9 @@ public boolean processControlCommand(Command c)
526526
if (method instanceof AMQP.Connection.CloseOk) {
527527
// It's our final "RPC". Time to shut down.
528528
_running = false;
529-
// If this was called from within the MainLoop we
530-
// may not have a continuation to return to, so we
531-
// treat this as processed in that case.
529+
// If Close was sent from within the MainLoop we
530+
// will not have a continuation to return to, so
531+
// we treat this as processed in that case.
532532
return _channel0._activeRpc == null;
533533
} else {
534534
// Ignore all others.

test/src/com/rabbitmq/client/test/CloseInMainLoop.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ public void testCloseOKNormallyReceived() throws Exception{
3636
assertTrue(connection.hadValidShutdown());
3737
}
3838

39+
// The thrown runtime exception should get intercepted by the
40+
// consumer exception handler, and result in a clean shut down.
3941
public void testCloseWithFaultyConsumer() throws Exception{
4042
SpecialConnection connection = new SpecialConnection();
4143
Channel channel = connection.createChannel();

0 commit comments

Comments
 (0)