Add a test to write/read BigDecimal

References #617

(cherry picked from commit 02284ea)

Conflicts:
	src/test/java/com/rabbitmq/client/test/ClientTests.java

Author: acogoluegnes

src/main/java/com/rabbitmq/client/impl/ValueReader.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2007-Present Pivotal Software, Inc.  All rights reserved.
+// Copyright (c) 2007-2019 Pivotal Software, Inc.  All rights reserved.
 //
 // This software, the RabbitMQ Java client library, is triple-licensed under the
 // Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
@@ -153,7 +153,8 @@ private static Map<String, Object> readTable(DataInputStream in)
         return table;
     }
 
-    private static Object readFieldValue(DataInputStream in)
+    // package protected for testing
+    static Object readFieldValue(DataInputStream in)
         throws IOException {
         Object value = null;
         switch(in.readUnsignedByte()) {

src/main/java/com/rabbitmq/client/impl/ValueWriter.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2007-Present Pivotal Software, Inc.  All rights reserved.
+// Copyright (c) 2007-2019 Pivotal Software, Inc.  All rights reserved.
 //
 // This software, the RabbitMQ Java client library, is triple-licensed under the
 // Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2

src/test/java/com/rabbitmq/client/impl/ValueWriterTest.java

@@ -1,16 +1,33 @@
+// Copyright (c) 2019 Pivotal Software, Inc.  All rights reserved.
+//
+// This software, the RabbitMQ Java client library, is triple-licensed under the
+// Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
+// ("GPL") and the Apache License version 2 ("ASL"). For the MPL, please see
+// LICENSE-MPL-RabbitMQ. For the GPL, please see LICENSE-GPL2.  For the ASL,
+// please see LICENSE-APACHE2.
+//
+// This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND,
+// either express or implied. See the LICENSE file for specific language governing
+// rights and limitations of this software.
+//
+// If you have any questions regarding licensing, please contact us at
+// [email protected].
+
 package com.rabbitmq.client.impl;
 
 import org.junit.Test;
 
-import java.io.DataOutputStream;
-import java.io.IOException;
-import java.io.OutputStream;
+import java.io.*;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 public class ValueWriterTest {
-    @Test(expected = IllegalArgumentException.class) public void writingOverlyLargeBigDecimalShouldFail()
-        throws IOException {
+
+    @Test(expected = IllegalArgumentException.class)
+    public void writingOverlyLargeBigDecimalShouldFail()
+            throws IOException {
 
         OutputStream outputStream = new OutputStream() {
             @Override
@@ -26,8 +43,9 @@ public void write(int b) {
 
     }
 
-    @Test(expected = IllegalArgumentException.class) public void writingOverlyLargeScaleInBigDecimalShouldFail()
-        throws IOException {
+    @Test(expected = IllegalArgumentException.class)
+    public void writingOverlyLargeScaleInBigDecimalShouldFail()
+            throws IOException {
 
         OutputStream outputStream = new OutputStream() {
             @Override
@@ -41,4 +59,16 @@ public void write(int b) {
 
         valueWriter.writeFieldValue(new BigDecimal(BigInteger.ONE, 500));
     }
+
+    @Test
+    public void bigDecimalWrittenAndReadMatches() throws IOException {
+        BigDecimal value = new BigDecimal(BigInteger.valueOf(56), 3);
+        ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
+        DataOutputStream dataOutputStream = new DataOutputStream(outputStream);
+        ValueWriter valueWriter = new ValueWriter(dataOutputStream);
+        valueWriter.writeFieldValue(value);
+
+        BigDecimal read = (BigDecimal) ValueReader.readFieldValue(new DataInputStream(new ByteArrayInputStream(outputStream.toByteArray())));
+        assertThat(read).isEqualTo(value);
+    }
 }

src/test/java/com/rabbitmq/client/test/ClientTests.java

@@ -18,6 +18,7 @@
 
 import com.rabbitmq.client.JacksonJsonRpcTest;
 import com.rabbitmq.client.DefaultJsonRpcTest;
+import com.rabbitmq.client.impl.ValueWriterTest;
 import com.rabbitmq.utility.IntAllocatorTests;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
@@ -71,7 +72,8 @@
     RpcTopologyRecordingTest.class,
     ConnectionTest.class,
     TlsUtilsTest.class,
-    ChannelNTest.class
+    ChannelNTest.class,
+    ValueWriterTest.class
 })
 public class ClientTests {