Remove unnecessary ConfigureAwait

Author: lukebakken

projects/RabbitMQ.Client/client/TaskExtensions.cs

@@ -65,7 +65,7 @@ static async Task DoTimeoutAfter(Task task, TimeSpan timeout)
                 using (var cts = new CancellationTokenSource())
                 {
                     Task delayTask = Task.Delay(timeout, cts.Token);
-                    Task resultTask = await Task.WhenAny(task, delayTask);
+                    Task resultTask = await Task.WhenAny(task, delayTask).ConfigureAwait(false);
                     if (resultTask == delayTask)
                     {
                         Task supressErrorTask = task.ContinueWith(

projects/RabbitMQ.Client/client/api/ITcpClient.cs

@@ -18,7 +18,9 @@ public interface ITcpClient : IDisposable
 
         Socket Client { get; }
 
+        // TODO CancellationToken
         Task ConnectAsync(string host, int port);
+        // TODO CancellationToken
         Task ConnectAsync(IPAddress host, int port);
 
         NetworkStream GetStream();

projects/RabbitMQ.Client/client/api/TcpClientAdapter.cs

@@ -34,10 +34,11 @@ await ConnectAsync(ep, port)
                 .ConfigureAwait(false);
         }
 
-        public virtual Task ConnectAsync(IPAddress ep, int port)
+        public virtual async Task ConnectAsync(IPAddress ep, int port)
         {
             AssertSocket();
-            return _sock.ConnectAsync(ep, port);
+            await _sock.ConnectAsync(ep, port)
+                .ConfigureAwait(false);
         }
 
         public virtual void Close()

projects/RabbitMQ.Client/client/impl/Connection.cs

@@ -213,8 +213,12 @@ internal void TakeOver(Connection other)
 
         internal IConnection Open()
         {
-            return OpenAsync()
-                .ConfigureAwait(false).GetAwaiter().GetResult();
+            /*
+             * https://devblogs.microsoft.com/dotnet/configureawait-faq/
+             * I'm using GetAwaiter().GetResult(). Do I need to use ConfigureAwait(false)?
+             * Answer: No
+             */
+            return OpenAsync().GetAwaiter().GetResult();
         }
 
         internal async ValueTask<IConnection> OpenAsync()
@@ -526,7 +530,12 @@ internal void Write(RentedMemory frames)
             ValueTask task = _frameHandler.WriteAsync(frames);
             if (!task.IsCompletedSuccessfully)
             {
-                task.ConfigureAwait(false).GetAwaiter().GetResult();
+                /*
+                 * https://devblogs.microsoft.com/dotnet/configureawait-faq/
+                 * I'm using GetAwaiter().GetResult(). Do I need to use ConfigureAwait(false)?
+                 * Answer: No
+                 */
+                task.GetAwaiter().GetResult();
             }
         }
 

projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs

@@ -183,7 +183,12 @@ public TimeSpan WriteTimeout
 
         public void Close()
         {
-            CloseAsync().ConfigureAwait(false).GetAwaiter().GetResult();
+            /*
+             * https://devblogs.microsoft.com/dotnet/configureawait-faq/
+             * I'm using GetAwaiter().GetResult(). Do I need to use ConfigureAwait(false)?
+             * Answer: No
+             */
+            CloseAsync().GetAwaiter().GetResult();
         }
 
         public async ValueTask CloseAsync()
@@ -336,7 +341,6 @@ private void ConnectOrFail(ITcpClient socket, IPEndPoint endpoint, TimeSpan time
             {
                 socket.ConnectAsync(endpoint.Address, endpoint.Port)
                      .TimeoutAfter(timeout)
-                     .ConfigureAwait(false)
                      // this ensures exceptions aren't wrapped in an AggregateException
                      .GetAwaiter()
                      .GetResult();

projects/Test/SequentialIntegration/TestConnectionRecoveryBase.cs

@@ -255,8 +255,12 @@ internal void RestartServerAndWaitForRecovery(AutorecoveringConnection conn)
         protected bool WaitForConfirms(IChannel m)
         {
             using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(4));
-            return m.WaitForConfirmsAsync(cts.Token)
-                .ConfigureAwait(false).GetAwaiter().GetResult();
+            /*
+             * https://devblogs.microsoft.com/dotnet/configureawait-faq/
+             * I'm using GetAwaiter().GetResult(). Do I need to use ConfigureAwait(false)?
+             * Answer: No
+             */
+            return m.WaitForConfirmsAsync(cts.Token).GetAwaiter().GetResult();
         }
 
         protected void WaitForRecovery()