Skip to content

Commit b79c261

Browse files
committed
* Remove two TODOs because resolving them resulted in too many other errors
1 parent 5adb0a8 commit b79c261

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

projects/RabbitMQ.Client/client/impl/ChannelBase.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,13 +505,19 @@ private void OnChannelShutdown(ShutdownEventArgs reason)
505505
_flowControlBlock.Set();
506506
}
507507

508-
// TODO async
508+
/*
509+
* Note:
510+
* Attempting to make this method async, with the resulting fallout,
511+
* resulted in many flaky test results, especially around disposing
512+
* Channels/Connections
513+
*
514+
* Aborted PR: https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1551
515+
*/
509516
private void OnSessionShutdown(object sender, ShutdownEventArgs reason)
510517
{
511518
ConsumerDispatcher.Quiesce();
512519
SetCloseReason(reason);
513520
OnChannelShutdown(reason);
514-
// TODO async
515521
ConsumerDispatcher.Shutdown(reason);
516522
}
517523

0 commit comments

Comments
 (0)