File tree Expand file tree Collapse file tree 1 file changed +8
-2
lines changed
projects/RabbitMQ.Client/client/impl Expand file tree Collapse file tree 1 file changed +8
-2
lines changed Original file line number Diff line number Diff line change @@ -505,13 +505,19 @@ private void OnChannelShutdown(ShutdownEventArgs reason)
505
505
_flowControlBlock . Set ( ) ;
506
506
}
507
507
508
- // TODO async
508
+ /*
509
+ * Note:
510
+ * Attempting to make this method async, with the resulting fallout,
511
+ * resulted in many flaky test results, especially around disposing
512
+ * Channels/Connections
513
+ *
514
+ * Aborted PR: https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1551
515
+ */
509
516
private void OnSessionShutdown ( object sender , ShutdownEventArgs reason )
510
517
{
511
518
ConsumerDispatcher . Quiesce ( ) ;
512
519
SetCloseReason ( reason ) ;
513
520
OnChannelShutdown ( reason ) ;
514
- // TODO async
515
521
ConsumerDispatcher . Shutdown ( reason ) ;
516
522
}
517
523
You can’t perform that action at this time.
0 commit comments