Skip to content

Commit 8479df4

Browse files
authored
all: use quasilyte/stdinfo, remove internal/stdinfo (#371)
Fixes #357
1 parent 20831c4 commit 8479df4

File tree

6 files changed

+20
-166
lines changed

6 files changed

+20
-166
lines changed

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ require (
88
github.com/quasilyte/go-ruleguard/dsl v0.3.15
99
github.com/quasilyte/go-ruleguard/rules v0.0.0-20211022131956-028d6511ab71
1010
github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5
11+
github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567
1112
golang.org/x/tools v0.1.9-0.20211228192929-ee1ca4ffc4da
1213
)
1314

go.sum

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,15 @@ github.com/google/go-cmp v0.5.6 h1:BKbKCqvP6I+rmFHt06ZmyQtvB8xAkWdhFyr0ZUNZcxQ=
1010
github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
1111
github.com/quasilyte/go-ruleguard v0.3.1-0.20210203134552-1b5a410e1cc8/go.mod h1:KsAh3x0e7Fkpgs+Q9pNLS5XpFSvYCEVl5gP9Pp1xp30=
1212
github.com/quasilyte/go-ruleguard/dsl v0.3.0/go.mod h1:KeCP03KrjuSO0H1kTuZQCWlQPulDV6YMIXmpQss17rU=
13-
github.com/quasilyte/go-ruleguard/dsl v0.3.13 h1:WmtzUkp28TMarzfBCogPf7plyI/2gsNsj8CgZ9ihPCM=
14-
github.com/quasilyte/go-ruleguard/dsl v0.3.13/go.mod h1:KeCP03KrjuSO0H1kTuZQCWlQPulDV6YMIXmpQss17rU=
15-
github.com/quasilyte/go-ruleguard/dsl v0.3.14 h1:diesHrFHZ6rxuFltuwiW7NRQaqUIypuSSmUulRCNuqM=
16-
github.com/quasilyte/go-ruleguard/dsl v0.3.14/go.mod h1:KeCP03KrjuSO0H1kTuZQCWlQPulDV6YMIXmpQss17rU=
1713
github.com/quasilyte/go-ruleguard/dsl v0.3.15 h1:rClYn6lk8wUV5kXnQG4JVsRQjZhSetaNtwml5wkFp5g=
1814
github.com/quasilyte/go-ruleguard/dsl v0.3.15/go.mod h1:KeCP03KrjuSO0H1kTuZQCWlQPulDV6YMIXmpQss17rU=
1915
github.com/quasilyte/go-ruleguard/rules v0.0.0-20201231183845-9e62ed36efe1/go.mod h1:7JTjp89EGyU1d6XfBiXihJNG37wB2VRkd125Q1u7Plc=
2016
github.com/quasilyte/go-ruleguard/rules v0.0.0-20211022131956-028d6511ab71 h1:CNooiryw5aisadVfzneSZPswRWvnVW8hF1bS/vo8ReI=
2117
github.com/quasilyte/go-ruleguard/rules v0.0.0-20211022131956-028d6511ab71/go.mod h1:4cgAphtvu7Ftv7vOT2ZOYhC6CvBxZixcasr8qIOTA50=
22-
github.com/quasilyte/gogrep v0.0.0-20220104185649-039753a3dd32 h1:fJhpG5LYGnHZqUIDULZkvQKJfdtAefNrkoiGCezlr7g=
23-
github.com/quasilyte/gogrep v0.0.0-20220104185649-039753a3dd32/go.mod h1:wSEyW6O61xRV6zb6My3HxrQ5/8ke7NE2OayqCHa3xRM=
2418
github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5 h1:PDWGei+Rf2bBiuZIbZmM20J2ftEy9IeUCHA8HbQqed8=
2519
github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5/go.mod h1:wSEyW6O61xRV6zb6My3HxrQ5/8ke7NE2OayqCHa3xRM=
20+
github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 h1:M8mH9eK4OUR4lu7Gd+PU1fV2/qnDNfzT635KRSObncs=
21+
github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567/go.mod h1:DWNGW8A4Y+GyBgPuaQJuWiy0XYftx4Xm/y5Jqk9I6VQ=
2622
github.com/yuin/goldmark v1.1.32/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
2723
github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
2824
github.com/yuin/goldmark v1.4.1/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=

internal/stdinfo/stdinfo.go

Lines changed: 0 additions & 151 deletions
This file was deleted.

ruleguard/engine.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ import (
1515
"sync"
1616

1717
"github.com/quasilyte/go-ruleguard/internal/goenv"
18-
"github.com/quasilyte/go-ruleguard/internal/stdinfo"
1918
"github.com/quasilyte/go-ruleguard/ruleguard/ir"
2019
"github.com/quasilyte/go-ruleguard/ruleguard/quasigo"
2120
"github.com/quasilyte/go-ruleguard/ruleguard/typematch"
21+
"github.com/quasilyte/stdinfo"
2222
)
2323

2424
type engine struct {
@@ -64,7 +64,7 @@ func (e *engine) Load(ctx *LoadContext, buildContext *build.Context, filename st
6464
pkg: pkg,
6565
ctx: ctx,
6666
importer: imp,
67-
itab: typematch.NewImportsTab(stdinfo.Packages),
67+
itab: typematch.NewImportsTab(stdinfo.PackagesList),
6868
gogrepFset: token.NewFileSet(),
6969
}
7070
l := newIRLoader(config)
@@ -97,7 +97,7 @@ func (e *engine) LoadFromIR(ctx *LoadContext, buildContext *build.Context, filen
9797
state: e.state,
9898
ctx: ctx,
9999
importer: imp,
100-
itab: typematch.NewImportsTab(stdinfo.Packages),
100+
itab: typematch.NewImportsTab(stdinfo.PackagesList),
101101
gogrepFset: token.NewFileSet(),
102102
}
103103
l := newIRLoader(config)

ruleguard/typematch/typematch.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"strings"
1111

1212
"github.com/quasilyte/go-ruleguard/internal/xtypes"
13+
"github.com/quasilyte/stdinfo"
1314
)
1415

1516
//go:generate stringer -type=patternOp
@@ -60,8 +61,12 @@ type ImportsTab struct {
6061
imports []map[string]string
6162
}
6263

63-
func NewImportsTab(initial map[string]string) *ImportsTab {
64-
return &ImportsTab{imports: []map[string]string{initial}}
64+
func NewImportsTab(initial []stdinfo.Package) *ImportsTab {
65+
convertMap := make(map[string]string)
66+
for _, pack := range initial {
67+
convertMap[pack.Name] = pack.Path
68+
}
69+
return &ImportsTab{imports: []map[string]string{convertMap}}
6570
}
6671

6772
func (itab *ImportsTab) Lookup(pkgName string) (string, bool) {

ruleguard/typematch/typematch_test.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import (
55
"go/types"
66
"path"
77
"testing"
8+
9+
"github.com/quasilyte/stdinfo"
810
)
911

1012
var (
@@ -14,6 +16,10 @@ var (
1416
typeUint8 = types.Typ[types.Uint8]
1517
typeUnsafePtr = types.Typ[types.UnsafePointer]
1618
typeEstruct = types.NewStruct(nil, nil)
19+
packages = [2]stdinfo.Package{
20+
{Name: "io", Path: "io"},
21+
{Name: "syntax", Path: "regexp/syntax"},
22+
}
1723

1824
stringerIface = types.NewInterfaceType([]*types.Func{
1925
types.NewFunc(token.NoPos, nil, "String",
@@ -26,10 +32,7 @@ var (
2632
stringVar = types.NewVar(token.NoPos, nil, "_", typeString)
2733

2834
testContext = &Context{
29-
Itab: NewImportsTab(map[string]string{
30-
"io": "io",
31-
"syntax": "regexp/syntax",
32-
}),
35+
Itab: NewImportsTab(packages[:]),
3336
}
3437
)
3538

0 commit comments

Comments
 (0)