Skip to content

Commit aea1a03

Browse files
quaffmp911de
authored andcommitted
Polishing.
Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes spring-projects#3452
1 parent cd12bd5 commit aea1a03

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spring-data-jpa/src/main/java/org/springframework/data/jpa/domain/Specification.java

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
* @author Daniel Shuy
4040
* @author Sergey Rukin
4141
*/
42+
@FunctionalInterface
4243
public interface Specification<T> extends Serializable {
4344

4445
@Serial long serialVersionUID = 1L;

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,9 @@
4646
* @author Mark Paluch
4747
* @author Daniel Shuy
4848
*/
49-
@SuppressWarnings("serial")
5049
@ExtendWith(MockitoExtension.class)
5150
@MockitoSettings(strictness = Strictness.LENIENT)
52-
class SpecificationUnitTests implements Serializable {
51+
class SpecificationUnitTests {
5352

5453
private Specification<Object> spec;
5554
@Mock(serializable = true) Root<Object> root;
@@ -163,7 +162,7 @@ void specificationsShouldBeSerializable() {
163162

164163
assertThat(specification).isNotNull();
165164

166-
@SuppressWarnings("unchecked")
165+
@SuppressWarnings({"unchecked", "deprecation"})
167166
Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
168167

169168
assertThat(transferredSpecification).isNotNull();
@@ -178,7 +177,7 @@ void complexSpecificationsShouldBeSerializable() {
178177

179178
assertThat(specification).isNotNull();
180179

181-
@SuppressWarnings("unchecked")
180+
@SuppressWarnings({"unchecked", "deprecation"})
182181
Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
183182

184183
assertThat(transferredSpecification).isNotNull();

0 commit comments

Comments
 (0)