ESLint: enable no-unused-vars on js files (#128)

Disabled on many lines to avoid potentially side effects in removing the variable.

Author: ficristo

.eslintrc.js

@@ -63,7 +63,7 @@ module.exports = {
         "no-shadow-restricted-names": "error",
         "no-shadow": "warn",
         "no-undef": "error",
-        "no-unused-vars": ["warn", {"vars": "all", "args": "none"}],
+        "no-unused-vars": ["error", {"vars": "all", "args": "none"}],
         "no-use-before-define": "off",
         // http://eslint.org/docs/rules/#nodejs-and-commonjs
         "no-new-require": "error",
@@ -174,6 +174,9 @@ module.exports = {
         {
             "files": [
                 "test/**",
+                "src/extensions/default/**/unittests.js",
+                "src/extensions/default/**/unittests.disabled.js",
+                "src/extensibility/node/spec/*.js"
             ],
             "env": {
                 "jasmine": true,

src/LiveDevelopment/Agents/RemoteFunctions.js

@@ -25,6 +25,7 @@
 /*jslint forin: true */
 /*global Node, MessageEvent */
 /*theseus instrument: false */
+/*exported RemoteFunctions*/
 
 /**
  * RemoteFunctions define the functions to be executed in the browser. This
@@ -384,8 +385,6 @@ function RemoteFunctions(config, remoteWSPort) {
                 }
             };
 
-            var mainBoxStyles = config.remoteHighlight.stylesToSet;
-
             var paddingVisualisations = [
               drawPaddingRect("top"),
               drawPaddingRect("right"),
@@ -431,8 +430,6 @@ function RemoteFunctions(config, remoteWSPort) {
 
             highlight.className = HIGHLIGHT_CLASSNAME;
 
-            var offset = _screenOffset(element);
-
             var el = element,
             offsetLeft = 0,
             offsetTop  = 0;
@@ -557,6 +554,7 @@ function RemoteFunctions(config, remoteWSPort) {
         }
     };
 
+    // eslint-disable-next-line no-unused-vars
     var _currentEditor;
     function _toggleEditor(element) {
         _currentEditor = new Editor(element);
@@ -1031,9 +1029,7 @@ function RemoteFunctions(config, remoteWSPort) {
     var _ws = null;
 
     function onDocumentClick(event) {
-        var element = event.target,
-            currentDataId,
-            newDataId;
+        var element = event.target;
 
         if (_ws && element && element.hasAttribute("data-brackets-id")) {
             _ws.send(JSON.stringify({

src/LiveDevelopment/LiveDevelopment.js

@@ -22,8 +22,6 @@
  *
  */
 
-/*global open */
-
 /**
  * LiveDevelopment manages the Inspector, all Agents, and the active LiveDocument
  *

src/LiveDevelopment/MultiBrowserImpl/language/HTMLSimpleDOM.js

@@ -267,7 +267,11 @@ define(function (require, exports, module) {
      */
     Builder.prototype.build = function (strict, markCache) {
         var self = this;
-        var token, lastClosedTag, lastTextNode, lastIndex = 0;
+        var token,
+            lastClosedTag,
+            lastTextNode,
+            // eslint-disable-next-line no-unused-vars
+            lastIndex = 0;
         var stack = this.stack;
         var attributeName = null;
         var nodeMap = {};

src/LiveDevelopment/MultiBrowserImpl/launchers/node/LauncherDomain.js

@@ -33,6 +33,7 @@ var open = require("opn");
  * The Brackets domain manager for registering node extensions.
  * @type {?DomainManager}
  */
+// eslint-disable-next-line no-unused-vars
 var _domainManager;
 
 /**

src/LiveDevelopment/MultiBrowserImpl/protocol/remote/DocumentObserver.js

@@ -22,8 +22,6 @@
  *
  */
 
-/*global setInterval, clearInterval */
-
 (function (global) {
     "use strict";
 
@@ -139,12 +137,12 @@
                 //        http://stackoverflow.com/questions/11425209/are-dom-mutation-observers-slower-than-dom-mutation-events
                 //
                 // TODO: This is just a temporary 'cross-browser' solution, it needs optimization.
-                var loadInterval = setInterval(function () {
+                var loadInterval = window.setInterval(function () {
                     var i;
                     for (i = 0; i < window.document.styleSheets.length; i++) {
                         if (window.document.styleSheets[i].href === href) {
                             //clear interval
-                            clearInterval(loadInterval);
+                            window.clearInterval(loadInterval);
                             // notify stylesheets added
                             self.notifyStylesheetAdded(href);
                             break;

src/brackets.js

@@ -76,6 +76,7 @@ define(function (require, exports, module) {
         DefaultDialogs      = require("widgets/DefaultDialogs"),
         ExtensionLoader     = require("utils/ExtensionLoader"),
         Async               = require("utils/Async"),
+        // eslint-disable-next-line no-unused-vars
         UpdateNotification  = require("utils/UpdateNotification"),
         UrlParams           = require("utils/UrlParams").UrlParams,
         PreferencesManager  = require("preferences/PreferencesManager"),

src/editor/CodeHintManager.js

@@ -247,8 +247,7 @@ define(function (require, exports, module) {
         hintList         = null,
         deferredHints    = null,
         keyDownEditor    = null,
-        codeHintsEnabled = true,
-        codeHintOpened   = false;
+        codeHintsEnabled = true;
 
 
     PreferencesManager.definePreference("showCodeHints", "boolean", true, {
@@ -378,7 +377,6 @@ define(function (require, exports, module) {
         }
         hintList.close();
         hintList = null;
-        codeHintOpened = false;
         keyDownEditor = null;
         sessionProvider = null;
         sessionEditor = null;

src/editor/Editor.js

@@ -2549,7 +2549,6 @@ define(function (require, exports, module) {
      * @param {string} name The name of the gutter to be unregistered.
      */
     Editor.unregisterGutter = function (name) {
-        var i, gutter;
         registeredGutters = registeredGutters.filter(function (gutter) {
             return gutter.name !== name;
         });

src/extensibility/node/spec/Installation.spec.js

@@ -24,7 +24,6 @@
 
 /*eslint-env node */
 /*jslint node: true */
-/*global expect, describe, it, beforeEach, afterEach */
 
 "use strict";
 

src/extensibility/node/spec/Validation.spec.js

@@ -24,7 +24,6 @@
 
 /*eslint-env node */
 /*jslint node: true */
-/*global expect, describe, it, afterEach */
 
 "use strict";
 

src/extensions/default/CSSAtRuleCodeHints/unittests.js

@@ -22,8 +22,6 @@
  *
  */
 
-/*global describe, it, xit, expect, beforeEach, afterEach */
-
 define(function (require, exports, module) {
     "use strict";
 
@@ -39,24 +37,6 @@ define(function (require, exports, module) {
 
         var testDocument, testEditor;
 
-        /*
-         * Create a mockup editor with the given content and language id.
-         *
-         * @param {string} content - content for test window
-         * @param {string} languageId
-         */
-        function setupTest(content, languageId) {
-            var mock = SpecRunnerUtils.createMockEditor(content, languageId);
-            testDocument = mock.doc;
-            testEditor = mock.editor;
-        }
-
-        function tearDownTest() {
-            SpecRunnerUtils.destroyMockEditor(testDocument);
-            testEditor = null;
-            testDocument = null;
-        }
-
         // Ask provider for hints at current cursor position; expect it to return some
         function expectHints(provider, implicitChar, returnWholeObj) {
             expect(provider.hasHints(testEditor, implicitChar)).toBe(true);
@@ -66,11 +46,6 @@ define(function (require, exports, module) {
             return returnWholeObj ? hintsObj : hintsObj.hints;
         }
 
-        // Ask provider for hints at current cursor position; expect it NOT to return any
-        function expectNoHints(provider, implicitChar) {
-            expect(provider.hasHints(testEditor, implicitChar)).toBe(false);
-        }
-
         // compares lists to ensure they are the same
         function verifyListsAreIdentical(hintList, values) {
             var i;
@@ -104,14 +79,6 @@ define(function (require, exports, module) {
             expect(hintList[0]).toBe(expectedFirstHint);
         }
 
-        // Helper function to
-        // a) ensure the hintList and the list with the available values have the same size
-        // b) ensure that all possible values are mentioned in the hintList
-        function verifyAllValues(hintList, values) {
-            expect(hintList.length).toBe(values.length);
-            expect(hintList.sort().toString()).toBe(values.sort().toString());
-        }
-
         var modesToTest = ["css", "scss", "less"],
             modeCounter;
 

src/extensions/default/CSSCodeHints/unittests.js

@@ -22,8 +22,6 @@
  *
  */
 
-/*global describe, it, xit, expect, beforeEach, afterEach */
-
 define(function (require, exports, module) {
     "use strict";
 

src/extensions/default/CSSPseudoSelectorHints/unittests.js

@@ -22,8 +22,6 @@
  *
  */
 
-/*global describe, it, xit, expect, beforeEach, afterEach */
-
 define(function (require, exports, module) {
     "use strict";
 
@@ -45,24 +43,6 @@ define(function (require, exports, module) {
 
         var testDocument, testEditor;
 
-        /*
-         * Create a mockup editor with the given content and language id.
-         *
-         * @param {string} content - content for test window
-         * @param {string} languageId
-         */
-        function setupTest(content, languageId) {
-            var mock = SpecRunnerUtils.createMockEditor(content, languageId);
-            testDocument = mock.doc;
-            testEditor = mock.editor;
-        }
-
-        function tearDownTest() {
-            SpecRunnerUtils.destroyMockEditor(testDocument);
-            testEditor = null;
-            testDocument = null;
-        }
-
         // Ask provider for hints at current cursor position; expect it to return some
         function expectHints(provider, implicitChar, returnWholeObj) {
             expect(provider.hasHints(testEditor, implicitChar)).toBe(true);
@@ -72,11 +52,6 @@ define(function (require, exports, module) {
             return returnWholeObj ? hintsObj : hintsObj.hints;
         }
 
-        // Ask provider for hints at current cursor position; expect it NOT to return any
-        function expectNoHints(provider, implicitChar) {
-            expect(provider.hasHints(testEditor, implicitChar)).toBe(false);
-        }
-
         // compares lists to ensure they are the same
         function verifyListsAreIdentical(hintList, values) {
             var i;
@@ -86,38 +61,10 @@ define(function (require, exports, module) {
             }
         }
 
-
-        function selectHint(provider, expectedHint, implicitChar) {
-            var hintList = expectHints(provider, implicitChar);
-            expect(hintList.indexOf(expectedHint)).not.toBe(-1);
-            return provider.insertHint(expectedHint);
-        }
-
-        // Helper function for testing cursor position
-        function fixPos(pos) {
-            if (!("sticky" in pos)) {
-                pos.sticky = null;
-            }
-            return pos;
-        }
-        function expectCursorAt(pos) {
-            var selection = testEditor.getSelection();
-            expect(fixPos(selection.start)).toEqual(fixPos(selection.end));
-            expect(fixPos(selection.start)).toEqual(fixPos(pos));
-        }
-
         function verifyFirstEntry(hintList, expectedFirstHint) {
             expect(hintList[0]).toBe(expectedFirstHint);
         }
 
-        // Helper function to
-        // a) ensure the hintList and the list with the available values have the same size
-        // b) ensure that all possible values are mentioned in the hintList
-        function verifyAllValues(hintList, values) {
-            expect(hintList.length).toBe(values.length);
-            expect(hintList.sort().toString()).toBe(values.sort().toString());
-        }
-
         var modesToTest = ["css", "scss", "less"],
             modeCounter;
 

src/extensions/default/CloseOthers/unittests.js

@@ -22,16 +22,16 @@
  *
  */
 
-/*global describe, it, expect, beforeEach, afterEach, runs, waitsForDone, spyOn */
-
 define(function (require, exports, module) {
     "use strict";
 
     var SpecRunnerUtils = brackets.getModule("spec/SpecRunnerUtils"),
         FileUtils		= brackets.getModule("file/FileUtils"),
         CommandManager,
         Commands,
+        // eslint-disable-next-line no-unused-vars
         Dialogs,
+        // eslint-disable-next-line no-unused-vars
         EditorManager,
         DocumentManager,
         MainViewManager,
@@ -41,9 +41,11 @@ define(function (require, exports, module) {
         var extensionPath = FileUtils.getNativeModuleDirectoryPath(module),
             testPath      = extensionPath + "/unittest-files/",
             testWindow,
+            // eslint-disable-next-line no-unused-vars
             $,
             docSelectIndex,
             cmdToRun,
+            // eslint-disable-next-line no-unused-vars
             brackets;
 
         function createUntitled(count) {

src/extensions/default/CodeFolding/foldhelpers/foldgutter.js

@@ -341,6 +341,7 @@ define(function (require, exports, module) {
       * @param {!Object} to the ch and line position that designates the end of the region
       */
     function onFold(cm, from, to) {
+        // eslint-disable-next-line no-unused-vars
         var state = cm.state.foldGutter;
         updateFoldInfo(cm, from.line, from.line + 1);
     }
@@ -352,6 +353,7 @@ define(function (require, exports, module) {
       * @param {!{line:number, ch:number}} to the ch and line position that designates the end of the region
       */
     function onUnFold(cm, from, to) {
+        // eslint-disable-next-line no-unused-vars
         var state = cm.state.foldGutter;
         var vp = cm.getViewport();
         delete cm._lineFolds[from.line];

src/extensions/default/CodeFolding/foldhelpers/handlebarsFold.js

@@ -30,8 +30,8 @@
 
 define(function (require, exports, module) {
     "use strict";
-    var CodeMirror  = brackets.getModule("thirdparty/CodeMirror/lib/codemirror"),
-        _           = brackets.getModule("thirdparty/lodash"),
+
+    var _           = brackets.getModule("thirdparty/lodash"),
         StringUtils = brackets.getModule("utils/StringUtils");
 
     /**

src/extensions/default/CodeFolding/unittests.js

@@ -4,8 +4,6 @@
  * @date 01/08/2015 18:34
  */
 
-/*global describe, xdescribe, beforeEach, afterEach, it, expect, runs, waitsForDone, waitsFor*/
-
 define(function (require, exports, module) {
     "use strict";
     var SpecRunnerUtils = brackets.getModule("spec/SpecRunnerUtils"),
@@ -24,6 +22,7 @@ define(function (require, exports, module) {
         var testWindow,
             testEditor,
             EditorManager,
+            // eslint-disable-next-line no-unused-vars
             DocumentManager,
             CommandManager,
             PreferencesManager,