ESLint: enable block-spacing rule and did a little cleanup (#131)

Author: ficristo

.eslintignore

@@ -68,7 +68,7 @@ module.exports = {
         // http://eslint.org/docs/rules/#nodejs-and-commonjs
         "no-new-require": "error",
         // http://eslint.org/docs/rules/#stylistic-issues
-        "block-spacing": "warn",
+        "block-spacing": "error",
         "brace-style": ["error", "1tbs", { allowSingleLine: true }],
         "camelcase": "warn",
         "comma-dangle": "error",
@@ -142,6 +142,13 @@ module.exports = {
         "XMLHttpRequest": false
     },
     "overrides": [
+        // src/
+        {
+            "files": [ "src/**" ],
+            "globals": {
+                "electron": false
+            }
+        },
         // TypeScript
         {
             "files": [ "**/*.ts" ],

.eslintrc.js

@@ -260,7 +260,7 @@ define(function (require, exports, module) {
       * @param {!Object} changeObj detailed information about the change that occurred in the document
       */
     function onChange(cm, changeObj) {
-        if (changeObj.origin === "setValue") {//text content has changed outside of brackets
+        if (changeObj.origin === "setValue") { // text content has changed outside of brackets
             var folds = cm.getValidFolds(cm._lineFolds);
             cm._lineFolds = folds;
             Object.keys(folds).forEach(function (line) {

src/.eslintrc.js

@@ -185,7 +185,7 @@ define(function (require, exports, module) {
      * @private
      */
     function _syncWithFileSystem() {
-        _mrofList = _mrofList.filter(function (e) {return e; });
+        _mrofList = _mrofList.filter(function (e) { return e; });
         return Async.doSequentially(_mrofList, _checkExt, false);
     }
 
@@ -431,7 +431,7 @@ define(function (require, exports, module) {
         }
 
         _syncWithFileSystem().always(function () {
-            _mrofList = _mrofList.filter(function (e) {return e; });
+            _mrofList = _mrofList.filter(function (e) { return e; });
             _createFileEntries($mrofList);
             var $fileLinks = $("#mrof-container #mrof-list > li > a.mroitem");
             // Handlers for mouse events on the list items
@@ -705,7 +705,7 @@ define(function (require, exports, module) {
         });
 
         // Clean the null/undefined entries
-        _mrofList = _mrofList.filter(function (e) {return e; });
+        _mrofList = _mrofList.filter(function (e) { return e; });
 
         PreferencesManager.setViewState(OPEN_FILES_VIEW_STATE, _mrofList, _getPrefsContext(), true);
     }

src/extensions/default/CodeFolding/foldhelpers/foldgutter.js

@@ -198,18 +198,18 @@ define(function (require, exports, module) {
                     expect(MainViewManager.getCurrentlyViewedFile(MainViewManager.ACTIVE_PANE)).toBeFalsy();
                 });
                 runs(function () {
-                    expect(function () {MainViewManager.setActivePaneId("second-pane"); }).toThrow();
+                    expect(function () { MainViewManager.setActivePaneId("second-pane"); }).toThrow();
                     expect(MainViewManager.getActivePaneId()).toNotEqual("second-pane");
                 });
                 runs(function () {
-                    expect(function () {MainViewManager.addToWorkingSet("second-pane", getFileObject("test.js")); }).toThrow();
+                    expect(function () { MainViewManager.addToWorkingSet("second-pane", getFileObject("test.js")); }).toThrow();
                     expect(MainViewManager.findInWorkingSet(MainViewManager.ALL_PANES, testPath + "/test.js")).toEqual(-1);
-                    expect(function () {MainViewManager.findInWorkingSet("second-pane", testPath + "/test.js"); }).toThrow();
+                    expect(function () { MainViewManager.findInWorkingSet("second-pane", testPath + "/test.js"); }).toThrow();
                 });
                 runs(function () {
-                    expect(function () {MainViewManager.addListToWorkingSet("second-pane", [getFileObject("test.js")]); }).toThrow();
+                    expect(function () { MainViewManager.addListToWorkingSet("second-pane", [getFileObject("test.js")]); }).toThrow();
                     expect(MainViewManager.findInWorkingSet(MainViewManager.ALL_PANES, testPath + "/test.js")).toEqual(-1);
-                    expect(function () {MainViewManager.findInWorkingSet("second-pane", testPath + "/test.js"); }).toThrow();
+                    expect(function () { MainViewManager.findInWorkingSet("second-pane", testPath + "/test.js"); }).toThrow();
                 });
             });
         });