Skip to content

Commit 5346a3a

Browse files
committed
BUG: closes pandas-dev#44312: fixes unwanted TypeError when a missing metadata field is missing
1 parent a3bcbf8 commit 5346a3a

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

pandas/io/json/_normalize.py

+2
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,8 @@ def _pull_field(
389389
try:
390390
if isinstance(spec, list):
391391
for field in spec:
392+
if result is None:
393+
raise KeyError()
392394
result = result[field]
393395
else:
394396
result = result[spec]

pandas/tests/io/json/test_normalize.py

+17
Original file line numberDiff line numberDiff line change
@@ -634,6 +634,23 @@ def test_missing_meta(self, missing_metadata):
634634
expected = DataFrame(ex_data, columns=columns)
635635
tm.assert_frame_equal(result, expected)
636636

637+
def test_missing_nested_meta(self):
638+
# GH44312
639+
# If errors="ignore" and metadata is null, we should it even if it's nested
640+
data = {"meta": "foo", "nested_meta": None, "value": [{"rec": 1}, {"rec": 2}]}
641+
result = json_normalize(
642+
data,
643+
record_path="value",
644+
meta=["meta", ["nested_meta", "leaf"]],
645+
errors="ignore",
646+
)
647+
ex_data = [["foo", np.nan, 1], ["foo", np.nan, 2]]
648+
columns = ["meta", "nested_meta.leaf", "rec"]
649+
expected = DataFrame(ex_data, columns=columns).astype(
650+
{"nested_meta.leaf": object}
651+
)
652+
tm.assert_frame_equal(result, expected, check_like=True)
653+
637654
def test_missing_meta_multilevel_record_path_errors_raise(self, missing_metadata):
638655
# GH41876
639656
# Ensure errors='raise' works as intended even when a record_path of length

0 commit comments

Comments
 (0)