Skip to content

Commit cc45bec

Browse files
authored
[mypyc] Make exception type check in assertRaises test helper precise (#18241)
1 parent f51090d commit cc45bec

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

mypyc/test-data/fixtures/testutil.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def assertRaises(typ: type, msg: str = '') -> Iterator[None]:
4545
try:
4646
yield
4747
except Exception as e:
48-
assert isinstance(e, typ), f"{e!r} is not a {typ.__name__}"
48+
assert type(e) is typ, f"{e!r} is not a {typ.__name__}"
4949
assert msg in str(e), f'Message "{e}" does not match "{msg}"'
5050
else:
5151
assert False, f"Expected {typ.__name__} but got no exception"

mypyc/test-data/run-i64.test

+9-9
Original file line numberDiff line numberDiff line change
@@ -1307,28 +1307,28 @@ def test_many_locals() -> None:
13071307
a31: i64 = 31
13081308
a32: i64 = 32
13091309
a33: i64 = 33
1310-
with assertRaises(NameError):
1310+
with assertRaises(UnboundLocalError):
13111311
print(a0)
1312-
with assertRaises(NameError):
1312+
with assertRaises(UnboundLocalError):
13131313
print(a31)
1314-
with assertRaises(NameError):
1314+
with assertRaises(UnboundLocalError):
13151315
print(a32)
1316-
with assertRaises(NameError):
1316+
with assertRaises(UnboundLocalError):
13171317
print(a33)
13181318
a0 = 5
13191319
assert a0 == 5
1320-
with assertRaises(NameError):
1320+
with assertRaises(UnboundLocalError):
13211321
print(a31)
1322-
with assertRaises(NameError):
1322+
with assertRaises(UnboundLocalError):
13231323
print(a32)
1324-
with assertRaises(NameError):
1324+
with assertRaises(UnboundLocalError):
13251325
print(a33)
13261326
a32 = 55
13271327
assert a0 == 5
13281328
assert a32 == 55
1329-
with assertRaises(NameError):
1329+
with assertRaises(UnboundLocalError):
13301330
print(a31)
1331-
with assertRaises(NameError):
1331+
with assertRaises(UnboundLocalError):
13321332
print(a33)
13331333
a31 = 10
13341334
a33 = 20

mypyc/test-data/run-misc.test

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ from testutil import assertRaises
3737

3838
f(True, True)
3939
f(False, False)
40-
with assertRaises(NameError):
40+
with assertRaises(UnboundLocalError):
4141
f(False, True)
42-
with assertRaises(NameError):
42+
with assertRaises(UnboundLocalError):
4343
g()
4444
[out]
4545
lol

mypyc/test-data/run-primitives.test

+2-2
Original file line numberDiff line numberDiff line change
@@ -345,10 +345,10 @@ delAttribute()
345345
delAttributeMultiple()
346346
with assertRaises(AttributeError):
347347
native.global_var
348-
with assertRaises(NameError, 'local variable "dummy" referenced before assignment'):
348+
with assertRaises(UnboundLocalError, 'local variable "dummy" referenced before assignment'):
349349
delLocal(True)
350350
assert delLocal(False) == 10
351-
with assertRaises(NameError, 'local variable "dummy" referenced before assignment'):
351+
with assertRaises(UnboundLocalError, 'local variable "dummy" referenced before assignment'):
352352
delLocalLoop()
353353
[out]
354354
(1, 2, 3)

0 commit comments

Comments
 (0)