Skip to content

Commit 4e7f79f

Browse files
committed
Revert "test_packages_distributions_all_module_types() must create existing files for all the entries in RECORD"
This reverts commit fa9cca4.
1 parent 5dbe83c commit 4e7f79f

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

tests/fixtures.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,6 @@ def build_files(file_defs, prefix=pathlib.Path()):
351351
full_name.mkdir()
352352
build_files(contents, prefix=full_name)
353353
else:
354-
full_name.parent.mkdir(parents=True, exist_ok=True)
355354
if isinstance(contents, bytes):
356355
with full_name.open('wb') as f:
357356
f.write(contents)

tests/test_main.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import unittest
44
import importlib
55
import importlib_metadata
6-
import itertools
76
import pyfakefs.fake_filesystem_unittest as ffs
87

98
from . import fixtures
@@ -339,30 +338,24 @@ def test_packages_distributions_all_module_types(self):
339338
Test top-level modules detected on a package without 'top-level.txt'.
340339
"""
341340
suffixes = importlib.machinery.all_suffixes()
342-
filenames = list(
343-
itertools.chain.from_iterable(
344-
[
345-
f'{i}-top-level{suffix}',
346-
f'{i}-in-namespace/mod{suffix}',
347-
f'{i}-in-package/__init__.py',
348-
f'{i}-in-package/mod{suffix}',
349-
]
350-
for i, suffix in enumerate(suffixes)
351-
)
352-
)
353341
fixtures.build_files(
354342
{
355343
'all_distributions-1.0.0.dist-info': {
356344
'METADATA': """
357345
Name: all_distributions
358346
Version: 1.0.0
359347
""",
360-
'RECORD': ''.join(f'{fname},,\n' for fname in filenames),
348+
'RECORD': ''.join(
349+
f'{i}-top-level{suffix},,\n'
350+
f'{i}-in-namespace/mod{suffix},,\n'
351+
f'{i}-in-package/__init__.py,,\n'
352+
f'{i}-in-package/mod{suffix},,\n'
353+
for i, suffix in enumerate(suffixes)
354+
),
361355
},
362356
},
363357
prefix=self.site_dir,
364358
)
365-
fixtures.build_files({fname: "" for fname in filenames}, prefix=self.site_dir)
366359

367360
distributions = packages_distributions()
368361

0 commit comments

Comments
 (0)