Skip to content

Commit 2be3507

Browse files
authored
Merge pull request #341 from hugovk/upgrade-syntax
Remove some redundant Python 2 code
2 parents 0c24c31 + 2a504fd commit 2be3507

File tree

6 files changed

+15
-22
lines changed

6 files changed

+15
-22
lines changed

docs/conf.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#!/usr/bin/env python3
2-
# -*- coding: utf-8 -*-
32

43
extensions = ['sphinx.ext.autodoc', 'jaraco.packaging.sphinx', 'rst.linker']
54

importlib_metadata/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ def names(self):
339339
"""
340340
Return the set of all names of all entry points.
341341
"""
342-
return set(ep.name for ep in self)
342+
return {ep.name for ep in self}
343343

344344
@property
345345
def groups(self):
@@ -350,7 +350,7 @@ def groups(self):
350350
>>> EntryPoints().groups
351351
set()
352352
"""
353-
return set(ep.group for ep in self)
353+
return {ep.group for ep in self}
354354

355355
@classmethod
356356
def _from_text_for(cls, text, dist):

importlib_metadata/_text.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def __hash__(self):
8080
return hash(self.lower())
8181

8282
def __contains__(self, other):
83-
return super(FoldedCase, self).lower().__contains__(other.lower())
83+
return super().lower().__contains__(other.lower())
8484

8585
def in_(self, other):
8686
"Does self appear in other?"
@@ -89,7 +89,7 @@ def in_(self, other):
8989
# cache lower since it's likely to be called frequently.
9090
@method_cache
9191
def lower(self):
92-
return super(FoldedCase, self).lower()
92+
return super().lower()
9393

9494
def index(self, sub):
9595
return self.lower().index(sub.lower())

tests/fixtures.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def setUp(self):
6262

6363
class SiteDir(Fixtures):
6464
def setUp(self):
65-
super(SiteDir, self).setUp()
65+
super().setUp()
6666
self.site_dir = self.fixtures.enter_context(tempdir())
6767

6868

@@ -77,7 +77,7 @@ def add_sys_path(dir):
7777
sys.path.remove(str(dir))
7878

7979
def setUp(self):
80-
super(OnSysPath, self).setUp()
80+
super().setUp()
8181
self.fixtures.enter_context(self.add_sys_path(self.site_dir))
8282

8383

@@ -114,7 +114,7 @@ def main():
114114
}
115115

116116
def setUp(self):
117-
super(DistInfoPkg, self).setUp()
117+
super().setUp()
118118
build_files(DistInfoPkg.files, self.site_dir)
119119

120120
def make_uppercase(self):
@@ -139,7 +139,7 @@ class DistInfoPkgWithDot(OnSysPath, SiteDir):
139139
}
140140

141141
def setUp(self):
142-
super(DistInfoPkgWithDot, self).setUp()
142+
super().setUp()
143143
build_files(DistInfoPkgWithDot.files, self.site_dir)
144144

145145

@@ -160,13 +160,13 @@ class DistInfoPkgWithDotLegacy(OnSysPath, SiteDir):
160160
}
161161

162162
def setUp(self):
163-
super(DistInfoPkgWithDotLegacy, self).setUp()
163+
super().setUp()
164164
build_files(DistInfoPkgWithDotLegacy.files, self.site_dir)
165165

166166

167167
class DistInfoPkgOffPath(SiteDir):
168168
def setUp(self):
169-
super(DistInfoPkgOffPath, self).setUp()
169+
super().setUp()
170170
build_files(DistInfoPkg.files, self.site_dir)
171171

172172

@@ -206,7 +206,7 @@ def main():
206206
}
207207

208208
def setUp(self):
209-
super(EggInfoPkg, self).setUp()
209+
super().setUp()
210210
build_files(EggInfoPkg.files, prefix=self.site_dir)
211211

212212

@@ -227,7 +227,7 @@ class EggInfoFile(OnSysPath, SiteDir):
227227
}
228228

229229
def setUp(self):
230-
super(EggInfoFile, self).setUp()
230+
super().setUp()
231231
build_files(EggInfoFile.files, prefix=self.site_dir)
232232

233233

tests/test_api.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -206,14 +206,8 @@ def _test_files(files):
206206
file.read_text()
207207

208208
def test_file_hash_repr(self):
209-
try:
210-
assertRegex = self.assertRegex
211-
except AttributeError:
212-
# Python 2
213-
assertRegex = self.assertRegexpMatches
214-
215209
util = [p for p in files('distinfo-pkg') if p.name == 'mod.py'][0]
216-
assertRegex(repr(util.hash), '<FileHash mode: sha256 value: .*>')
210+
self.assertRegex(repr(util.hash), '<FileHash mode: sha256 value: .*>')
217211

218212
def test_files_dist_info(self):
219213
self._test_files(files('distinfo-pkg'))

tests/test_main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ class InaccessibleSysPath(fixtures.OnSysPath, ffs.TestCase):
208208
site_dir = '/access-denied'
209209

210210
def setUp(self):
211-
super(InaccessibleSysPath, self).setUp()
211+
super().setUp()
212212
self.setUpPyfakefs()
213213
self.fs.create_dir(self.site_dir, perm_bits=000)
214214

@@ -222,7 +222,7 @@ def test_discovery(self):
222222

223223
class TestEntryPoints(unittest.TestCase):
224224
def __init__(self, *args):
225-
super(TestEntryPoints, self).__init__(*args)
225+
super().__init__(*args)
226226
self.ep = importlib_metadata.EntryPoint('name', 'value', 'group')
227227

228228
def test_entry_point_pickleable(self):

0 commit comments

Comments
 (0)