Skip to content

Commit 4de8830

Browse files
Fixed post meetup button position (was too close to other elements, especially on iphone).
Moved Learn More button away from section above on mobiles. Added command to test jekyll build on local area network in _config_dev.yml - useful to confirm all works on various devices (chrome dev tools sometimes fail). Added logic to change link under "Learn More" button in Upcoming Events to meetup link if no dedicated page for upcoming event present (which should mostly be the case).
1 parent 8d66dd3 commit 4de8830

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

_config_dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ collections:
2525
- sponsors
2626

2727
# command to run build locally:
28-
# bundle exec jekyll serve --config _config.yml,_config_dev.yml
28+
# bundle exec jekyll serve --host 0.0.0.0 --config _config.yml,_config_dev.yml

_sass/post.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
@extend .button-standard;
4747
min-width: 50%;
4848
font-size: 1.25em;
49+
margin-top: 0.5em;
50+
margin-bottom: 1em;
4951
&:hover > .post__icon {
5052
color: $button-text-hover;
5153
}

_sass/style.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ a {
281281
border: #000000 2px groove;
282282
box-shadow: rgba(0, 0, 0, 0.76) 5px 5px 5px 0;
283283
min-height: 100%;
284+
margin-top: 1em;
284285
}
285286

286287
@media (min-width: 768px) {
@@ -336,7 +337,7 @@ a {
336337

337338
.upcoming__button-row {
338339
margin-top: 10%;
339-
margin-bottom: 5.5%;
340+
margin-bottom: 10%;
340341
}
341342

342343
@media (min-width: 768px) {

index.html

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,12 @@ <h2 class="upcoming__event-label">Sponsors</h2>
164164
</div>
165165
<div class="upcoming__button-row row">
166166
<div class="col-md-12 text-center">
167-
<a class="upcoming__link" href="{{ post.event_link }}">
167+
{% if post.event_link %}
168+
{% assign upcoming_event_link = post.event_link %}
169+
{% else %}
170+
{% assign upcoming_event_link = post.meetup_link %}
171+
{% endif %}
172+
<a class="upcoming__link" href="{{ upcoming_event_link }}">
168173
<button class="button-standard btn btn-lg">
169174
Learn More
170175
</button>

0 commit comments

Comments
 (0)