Skip to content

Commit 7c48f12

Browse files
committed
add explanatory comment for USE_WIN32_FILEIO
1 parent 1105c5d commit 7c48f12

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

setup.py

+4
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,10 @@ def build_extensions(self):
728728
libs.append(feature.tiff)
729729
defs.append(("HAVE_LIBTIFF", None))
730730
if sys.platform == "win32":
731+
# This define needs to be defined if-and-only-if it was defined
732+
# when compiling LibTIFF. LibTIFF doesn't expose it in `tiffconf.h`,
733+
# so we have to guess; by default it is defined in all Windows builds.
734+
# See #4237, #5243, #5359 for more information.
731735
defs.append(("USE_WIN32_FILEIO", None))
732736
if feature.xcb:
733737
libs.append(feature.xcb)

0 commit comments

Comments
 (0)