-
Notifications
You must be signed in to change notification settings - Fork 2
Distinguish ambiguous column value of None
#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
None
None
None
None
None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starcat37 @mikaniz
변경하면 좋을 부분 A / B 파트로 나눠서 코멘트 남겨뒀는데요, (코멘트 앞의 (A)
/ (B)
)
진아님 수인님 상의하셔서 각각 파트 정하시고 진행해주시면 좋을 것 같아요!
(A파트 맡으시는 분께서 먼저 진행하신 뒤 B파트 맡으시는 분께서 진행해주시면 될 것 같습니다🙂)
주로 변수명 변경 위주이긴 한데요,
구조를 파악하고 있어야 변경하기 쉬운 부분들도 있을 것 같아서
작업하시다가 어려운 부분 있으시면 말씀해주세요! :)
Since column schema has deleted, we cannot get any none sources when optional_meta_data is False.
@mikaniz @starcat37 추가로 최신 main 브랜치 pull 받아보니 그래서 self.__optional_meta_data = True로 변경해서 정상 동작하는 것 확인했고, 한번 같이 리뷰해주시면 반영해서 upstream PR에도 올려두겠습니다 :)
|
…ython-mysql-replication into feature/categorize-none-column
3011ef9
to
4c797a1
Compare
When we do not know columnInformation values dictionary key is always null so overwrite value Object. Thus always values dictionary has last order column object value To avoid user confusion, it is marked and displayed as UNKNOWN_COL.
…-column-only fix last order column only when DML
Resolve #39
Overview
In RowsEvent, there are three cases in which the column value is
None
.NULL
(ex: '0000-00-00 00:00:00')
Since we cannot distinguish these cases, we're going to provide detail information for
None
value.Changes
__none_sources
variable.__read_values_name
,we check detail information for
None
cases and save it to__none_sources
.dump()
executes, we check for none_sources and show them together with column name and value.Example