Small optimization

Author: julien-duponchelle

pymysqlreplication/column.py

@@ -92,7 +92,7 @@ def serializable_data(self):
         return self.data
 
     def __getattr__(self, item):
-        if item in self.data:
+        try:
             return self.data[item]
-        else:
+        except KeyError:
             raise AttributeError("{0} not found".format(item))

pymysqlreplication/table.py

@@ -22,9 +22,9 @@ def __init__(self, column_schemas, table_id, schema, table, columns, primary_key
         }
 
     def __getattr__(self, item):
-        if item in self.data:
+        try:
             return self.data[item]
-        else:
+        except KeyError:
             raise AttributeError
 
     def __eq__(self, other):

pymysqlreplication/tests/benchmark.py

@@ -11,13 +11,29 @@
 import os
 from pymysqlreplication import BinLogStreamReader
 from pymysqlreplication.row_event import *
+import cProfile
 
 
 def execute(con, query):
     c = con.cursor()
     c.execute(query)
     return c
 
+def consume_events():
+    stream = BinLogStreamReader(connection_settings=database,
+                                server_id=3,
+                                resume_stream=False,
+                                blocking=True,
+                                only_events = [UpdateRowsEvent])
+    start = time.clock()
+    i = 0.0
+    for binlogevent in stream:
+            i += 1.0
+            if i % 1000 == 0:
+                print("%d event by seconds (%d total)" % (i / (time.clock() - start), i))
+    stream.close()
+
+
 database = {
     "host": "localhost",
     "user": "root",
@@ -36,22 +52,11 @@ def execute(con, query):
 execute(conn, "INSERT INTO test VALUES(1)")
 execute(conn, "RESET MASTER")
 
+
 if os.fork() != 0:
     print("Start insert data")
     while True:
         execute(conn, "UPDATE test SET i = i + 1;")
 else:
-    stream = BinLogStreamReader(connection_settings=database,
-                                server_id=3,
-                                resume_stream=False,
-                                blocking=True,
-                                only_events = [UpdateRowsEvent])
-    start = time.clock()
-    i = 0.0
-    for binlogevent in stream:
-            i += 1.0
-            if i % 1000 == 0:
-                print("%d event by seconds (%d total)" % (i / (time.clock() - start), i))
-    stream.close()
-
+    cProfile.run('consume_events()')