refactor: split tests by db

Author: heehehe

.github/workflows/pytest.yml

@@ -1,6 +1,7 @@
 name: PyTest
 on: [push, pull_request]
-
+env:
+  PYTEST_SKIP_OPTION: "not test_no_trailing_rotate_event and not test_end_log_pos and not test_query_event_latin1"
 jobs:
   test:
     strategy:
@@ -29,31 +30,34 @@ jobs:
           docker compose create
           docker compose start
           echo "wait mysql server"
-        
+
           while :
           do
-            if mysql -h 127.0.0.1 --user=root --execute "SELECT version();" 2>&1 >/dev/null && mysql -h 127.0.0.1 --port=3307  --user=root --execute "SELECT version();" 2>&1 >/dev/null; then
+            if mysql -h 127.0.0.1 --user=root --execute "SELECT version();" 2>&1 >/dev/null && mysql -h 127.0.0.1 --port=3307 --user=root --execute "SELECT version();" 2>&1 >/dev/null; then
               break
             fi
             sleep 1
           done
-          
+
           echo "run pytest"
 
       - name: Install dependencies
         run: |
           pip install .
           pip install pytest
 
-      - name: Run test suite
+      - name: Run tests for mysql-5
         working-directory: pymysqlreplication/tests
-        run: |
-          dbms_versions=("mysql-5" "mysql-5-ctl" "mysql-8")
-          for version in "${dbms_versions[@]}"; do
-            pytest -k "not test_no_trailing_rotate_event and not test_end_log_pos and not test_query_event_latin1" --dbms=$version
-          done
+        run: pytest -k "$PYTEST_SKIP_OPTION" --db=mysql-5
 
-      - name: Run tests for MariaDB
+      - name: Run tests for mysql-5-ctl
         working-directory: pymysqlreplication/tests
-        run: |
-          pytest -m mariadb -k "not test_no_trailing_rotate_event and not test_end_log_pos and not test_query_event_latin1" --dbms=mariadb-10
+        run: pytest -k "$PYTEST_SKIP_OPTION" --db=mysql-5-ctl
+
+      - name: Run tests for mysql-8
+        working-directory: pymysqlreplication/tests
+        run: pytest -k "$PYTEST_SKIP_OPTION" --db=mysql-8
+
+      - name: Run tests for mariadb-10
+        working-directory: pymysqlreplication/tests
+        run: pytest -k "$PYTEST_SKIP_OPTION" -m mariadb --db=mariadb-10

pymysqlreplication/tests/base.py

@@ -25,11 +25,11 @@ def ignoredEvents(self):
         return []
 
     @pytest.fixture(autouse=True)
-    def setUpDBMS(self, get_dbms):
+    def setUpDatabase(self, get_db):
         databases = get_databases()
         # For local testing, set the get_dbms parameter to one of the following values: 'mysql-5', 'mysql-8', mariadb-10'.
         # This value should correspond to the desired database configuration specified in the 'config.json' file.
-        self.database = databases[get_dbms]
+        self.database = databases[get_db]
         """
         self.database = {
             "host": os.environ.get("MYSQL_5_7") or "localhost",

pymysqlreplication/tests/conftest.py

@@ -2,9 +2,9 @@
 
 
 def pytest_addoption(parser):
-    parser.addoption("--dbms", action="store", default="mysql-5")
+    parser.addoption("--db", action="store", default="mysql-5")
 
 
 @pytest.fixture
-def get_dbms(request):
-    return request.config.getoption("--dbms")
+def get_db(request):
+    return request.config.getoption("--db")