Skip to content

Commit b4a3340

Browse files
committed
Merge branch 'windows'
* windows: Reskip the PyPy-on-Windows tests. Try the Twisted prerelease, which hopefully obviates installing IOCP. No, don't use venv. Fix test to windows path matching Test via PyPy3.7 Unskip most of the skipped windows builds.
2 parents ff68d7b + d01a699 commit b4a3340

File tree

3 files changed

+26
-93
lines changed

3 files changed

+26
-93
lines changed

.github/workflows/ci.yml

Lines changed: 24 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@ jobs:
1717
matrix:
1818
os: [macos-latest, ubuntu-latest, windows-latest]
1919
python-version:
20-
- name: pypy3
20+
- name: pypy-3.7
2121
toxenv: pypy3-noextra-build
22-
- name: pypy3
22+
- name: pypy-3.7
2323
toxenv: pypy3-noextra-tests
24-
- name: pypy3
24+
- name: pypy-3.7
2525
toxenv: pypy3-format-build
26-
- name: pypy3
26+
- name: pypy-3.7
2727
toxenv: pypy3-format-tests
28-
- name: pypy3
28+
- name: pypy-3.7
2929
toxenv: pypy3-format_nongpl-build
30-
- name: pypy3
30+
- name: pypy-3.7
3131
toxenv: pypy3-format_nongpl-tests
3232
- name: 3.6
3333
toxenv: py36-noextra-build
@@ -98,104 +98,40 @@ jobs:
9898
exclude:
9999
- os: windows-latest
100100
python-version:
101-
name: pypy3
102-
toxenv: pypy3-noextra-build
103-
- os: windows-latest
104-
python-version:
105-
name: pypy3
106-
toxenv: pypy3-format-build
107-
- os: windows-latest
108-
python-version:
109-
name: pypy3
110-
toxenv: pypy3-format_nongpl-build
111-
- os: windows-latest
112-
python-version:
113-
name: pypy3
114-
toxenv: pypy3-noextra-tests
115-
- os: windows-latest
116-
python-version:
117-
name: pypy3
118-
toxenv: pypy3-format-tests
119-
- os: windows-latest
120-
python-version:
121-
name: pypy3
122-
toxenv: pypy3-format_nongpl-tests
123-
- os: windows-latest
124-
python-version:
125-
name: pypy3
126-
toxenv: safety
127-
- os: windows-latest
128-
python-version:
129-
name: 3.6
130-
toxenv: py36-noextra-build
131-
- os: windows-latest
132-
python-version:
133-
name: 3.6
134-
toxenv: py36-format-build
135-
- os: windows-latest
136-
python-version:
137-
name: 3.6
138-
toxenv: py36-format_nongpl-build
139-
- os: windows-latest
140-
python-version:
141-
name: 3.6
142-
toxenv: py36-noextra-tests
143-
- os: windows-latest
144-
python-version:
145-
name: 3.6
146-
toxenv: py36-format-tests
147-
- os: windows-latest
148-
python-version:
149-
name: 3.6
150-
toxenv: py36-format_nongpl-tests
151-
- os: windows-latest
152-
python-version:
153-
name: 3.7
154-
toxenv: py37-noextra-tests
155-
- os: windows-latest
156-
python-version:
157-
name: 3.7
158-
toxenv: py37-format-tests
159-
- os: windows-latest
160-
python-version:
161-
name: 3.7
162-
toxenv: py37-format_nongpl-tests
163-
- os: windows-latest
164-
python-version:
165-
name: 3.8
166-
toxenv: py38-noextra-tests
101+
name: 3.9
102+
toxenv: readme
167103
- os: windows-latest
168104
python-version:
169-
name: 3.8
170-
toxenv: py38-format-tests
105+
name: 3.9
106+
toxenv: docs-linkcheck
171107
- os: windows-latest
172108
python-version:
173-
name: 3.8
174-
toxenv: py38-format_nongpl-tests
109+
name: 3.9
110+
toxenv: docs-style
175111
- os: windows-latest
176112
python-version:
177-
name: 3.9
178-
toxenv: py39-noextra-tests
113+
name: pypy-3.7
114+
toxenv: pypy3-noextra-build
179115
- os: windows-latest
180116
python-version:
181-
name: 3.9
182-
toxenv: py39-format-tests
117+
name: pypy-3.7
118+
toxenv: pypy3-noextra-tests
183119
- os: windows-latest
184120
python-version:
185-
name: 3.9
186-
toxenv: py39-format_nongpl-tests
121+
name: pypy-3.7
122+
toxenv: pypy3-format-build
187123
- os: windows-latest
188124
python-version:
189-
name: 3.9
190-
toxenv: readme
125+
name: pypy-3.7
126+
toxenv: pypy3-format-tests
191127
- os: windows-latest
192128
python-version:
193-
name: 3.9
194-
toxenv: docs-linkcheck
129+
name: pypy-3.7
130+
toxenv: pypy3-format_nongpl-build
195131
- os: windows-latest
196132
python-version:
197-
name: 3.9
198-
toxenv: docs-style
133+
name: pypy-3.7
134+
toxenv: pypy3-format_nongpl-tests
199135

200136
steps:
201137
- uses: actions/checkout@v2
@@ -215,8 +151,5 @@ jobs:
215151
if: runner.os == 'macOS' && startsWith(matrix.python-version.toxenv, 'docs-')
216152
- name: Install tox
217153
run: python -m pip install tox
218-
- name: Use venv on Windows
219-
run: python -m pip install tox-venv
220-
if: runner.os == 'Windows'
221154
- name: Run tox
222155
run: python -m tox -e "${{ matrix.python-version.toxenv }}"

jsonschema/tests/test_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@ def test_nonexistent_file_with_explicit_base_uri(self):
747747
],
748748
)
749749
error = str(e.exception)
750-
self.assertIn("/someNonexistentFile.json'", error)
750+
self.assertIn(f"{os.sep}someNonexistentFile.json'", error)
751751

752752
def test_invalid_exlicit_base_uri(self):
753753
schema = '{"$ref": "foo.json#definitions/num"}'

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ deps =
4343

4444
perf: pyperf
4545

46-
tests,coverage,codecov: twisted
46+
tests,coverage,codecov: twisted>=21.2.0rc1
4747

4848
coverage,codecov: coverage
4949
codecov: codecov

0 commit comments

Comments
 (0)