Preserve the old behavior of defining default types.

This preserves backwards compatibility, even if it makes more
sense to start from scratch.

One can still get a fresh set of types by passing a different value in
for type_checker.

Closes: #509.

Author: Julian

jsonschema/tests/test_validators.py

@@ -121,6 +121,23 @@ def test_validates_registers_meta_schema_draft6_id(self):
 
         self.assertIn(meta_schema_key, validators.meta_schemas)
 
+    def test_create_default_types(self):
+        Validator = validators.create(meta_schema={}, validators=())
+        self.assertTrue(
+            all(
+                Validator({}).is_type(instance=instance, type=type)
+                for type, instance in [
+                    (u"array", []),
+                    (u"boolean", True),
+                    (u"integer", 12),
+                    (u"null", None),
+                    (u"number", 12.0),
+                    (u"object", {}),
+                    (u"string", u"foo"),
+                ]
+            ),
+        )
+
     def test_extend(self):
         original = dict(self.Validator.VALIDATORS)
         new = object()
@@ -153,17 +170,19 @@ def test_extend(self):
 
 
 class TestLegacyTypeChecking(SynchronousTestCase):
-    @unittest.skip("This logic is actually incorrect.")
-    def test_default_types_used_if_no_type_checker_given(self):
-        Validator = validators.create(
-            meta_schema=self.meta_schema,
-            validators=self.validators,
+    def test_create_default_types(self):
+        Validator = validators.create(meta_schema={}, validators=())
+        self.assertEqual(
+            set(Validator.DEFAULT_TYPES), {
+                u"array",
+                u"boolean",
+                u"integer",
+                u"null",
+                u"number",
+                u"object", u"string",
+            },
         )
-
-        expected_types = {u"array", u"boolean", u"integer", u"null", u"number",
-                          u"object", u"string"}
-
-        self.assertEqual(set(Validator.DEFAULT_TYPES), expected_types)
+        self.flushWarnings()
 
     def test_types_redefines_the_validators_type_checker(self):
         schema = {"type": "string"}

jsonschema/validators.py

@@ -173,8 +173,8 @@ def create(
 
             a type checker, used when applying the :validator:`type` validator.
 
-            If unprovided, an empty `jsonschema.TypeChecker` will created with
-            no known default types.
+            If unprovided, a `jsonschema.TypeChecker` will be created with
+            a set of default types typical of JSON Schema drafts.
 
         default_types (collections.Mapping):
 
@@ -216,7 +216,9 @@ def create(
         default_types = _DEPRECATED_DEFAULT_TYPES
         _created_with_default_types = False
         if type_checker is None:
-            type_checker = _types.TypeChecker()
+            type_checker = _types.TypeChecker(
+                type_checkers=_generate_legacy_type_checks(default_types),
+            )
 
     @add_metaclass(_DefaultTypesDeprecatingMetaClass)
     class Validator(object):