Merge remote-tracking branch 'manycoding/regex_value_validation'

* manycoding/regex_value_validation:
  Set format_checker to None for draft3 and 4
  Move test_invalid_pattern under Draft6 and 7
  Enable invalid regex tests
  Move regex patternProperty to InvalidRegexMixin
  Add propertyNames to Draft6 patternProperties, do not skip patternProperties test
  Pass draft7_format_checker to meta schema, set default Validator format_checker to None
  Revert style changes and test_it_does_not_validate_formats_by_default
  Fix test_it_validates_formats_by_default
  Add quotes back to False schema does not allow
  Fix test_False_schema
  Update test_it_validates_formats_by_default
  Ignore test_invalid_patternProperty
  Add invalid_patternProperty test
  Add invalid pattern tests
  Pass format_checker to validator in check_schema
  Pass format_checkers to meta schemas
  Fix regex output msg
  Return regex pattern error if regex failed to compile

Author: Julian

jsonschema/tests/test_validators.py

@@ -1124,6 +1124,26 @@ def test_enum_allows_non_unique_items(self):
         self.Validator.check_schema({"enum": [12, 12]})
 
 
+class InvalidRegexMixin(object):
+    def test_invalid_patternProperty(self):
+        with self.assertRaises(exceptions.SchemaError):
+            self.Validator.check_schema(
+                {"patternProperties":{"\q": {"type": "number"}}},
+            )
+
+    def test_invalid_pattern(self):
+        with self.assertRaises(exceptions.SchemaError):
+            self.Validator.check_schema({"pattern": "\q"})
+
+
+class TestDraft6InvalidRegex(InvalidRegexMixin, TestCase):
+    Validator = validators.Draft6Validator
+
+
+class TestDraft7InvalidRegex(InvalidRegexMixin, TestCase):
+    Validator = validators.Draft7Validator
+
+
 class ValidatorTestMixin(MetaSchemaTestsMixin, object):
     def test_valid_instances_are_valid(self):
         schema, instance = self.valid

jsonschema/validators.py

@@ -27,6 +27,11 @@
     urlsplit,
 )
 
+from jsonschema._format import (
+    draft6_format_checker,
+    draft7_format_checker,
+)
+
 # Sigh. https://gitlab.com/pycqa/flake8/issues/280
 #       https://github.com/pyga/ebb-lint/issues/7
 # Imported for backwards compatibility.
@@ -158,6 +163,7 @@ def create(
     default_types=None,
     type_checker=None,
     id_of=_id_of,
+    format_checker=None
 ):
     """
     Create a new validator class.
@@ -284,8 +290,9 @@ def __init__(
             self.schema = schema
 
         @classmethod
-        def check_schema(cls, schema):
-            for error in cls(cls.META_SCHEMA).iter_errors(schema):
+        def check_schema(cls, schema, format_checker=format_checker):
+            validator = cls(cls.META_SCHEMA, format_checker=format_checker)
+            for error in validator.iter_errors(schema):
                 raise exceptions.SchemaError.create_from(error)
 
         def iter_errors(self, instance, _schema=None):
@@ -465,6 +472,7 @@ def extend(validator, validators=(), version=None, type_checker=None):
     type_checker=_types.draft3_type_checker,
     version="draft3",
     id_of=lambda schema: schema.get(u"id", ""),
+    format_checker=None,
 )
 
 Draft4Validator = create(
@@ -500,6 +508,7 @@ def extend(validator, validators=(), version=None, type_checker=None):
     type_checker=_types.draft4_type_checker,
     version="draft4",
     id_of=lambda schema: schema.get(u"id", ""),
+    format_checker=None,
 )
 
 Draft6Validator = create(
@@ -539,6 +548,7 @@ def extend(validator, validators=(), version=None, type_checker=None):
     },
     type_checker=_types.draft6_type_checker,
     version="draft6",
+    format_checker=draft6_format_checker,
 )
 
 Draft7Validator = create(
@@ -579,6 +589,7 @@ def extend(validator, validators=(), version=None, type_checker=None):
     },
     type_checker=_types.draft7_type_checker,
     version="draft7",
+    format_checker=draft7_format_checker,
 )
 
 _LATEST_VERSION = Draft7Validator