Skip to content

Commit 22701dc

Browse files
committed
Fix test failures
1 parent 2fda155 commit 22701dc

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

jsonschema/tests/test_validators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ def test_it_retrieves_unstored_refs_via_urlopen(self):
815815
def test_it_can_construct_a_base_uri_from_a_schema(self):
816816
schema = {"id" : "foo"}
817817
resolver = RefResolver.from_schema(schema)
818-
self.assertEqual(resolver.base_uri, "foo")
818+
self.assertEqual(resolver.base_uri.url, "foo")
819819
with resolver.resolving("") as resolved:
820820
self.assertEqual(resolved, schema)
821821
with resolver.resolving("#") as resolved:
@@ -828,7 +828,7 @@ def test_it_can_construct_a_base_uri_from_a_schema(self):
828828
def test_it_can_construct_a_base_uri_from_a_schema_without_id(self):
829829
schema = {}
830830
resolver = RefResolver.from_schema(schema)
831-
self.assertEqual(resolver.base_uri, "")
831+
self.assertEqual(resolver.base_uri.url, "")
832832
with resolver.resolving("") as resolved:
833833
self.assertEqual(resolved, schema)
834834
with resolver.resolving("#") as resolved:

jsonschema/validators.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ class RefResolver(object):
229229
230230
:argument str base_uri: URI of the referring document
231231
:argument referrer: the actual referring document
232-
:argument dict store: a mapping from URIs (without fragments!) to documents to cache
232+
:argument dict store: a mapping from URIs to documents to cache
233233
:argument bool cache_remote: whether remote refs should be cached after
234234
first resolution
235235
:argument dict handlers: a mapping from URI schemes to functions that
@@ -275,7 +275,7 @@ def push_scope(self, scope, is_defragged=False):
275275
scope = urldefrag(scope)
276276
self.resolution_scope = DefragResult(
277277
urljoin(old_scope.url, scope.url, allow_fragments=False)
278-
if scope.url else old_scope.url,
278+
if scope.url else old_scope.url,
279279
scope.fragment
280280
)
281281

@@ -294,8 +294,13 @@ def resolving(self, ref):
294294

295295
ref = urldefrag(ref)
296296

297-
url = urljoin(self.resolution_scope.url, ref.url, allow_fragments=False) \
298-
if ref.url else self.resolution_scope.url
297+
if ref.url:
298+
url = urljoin(
299+
self.resolution_scope.url,
300+
ref.url,
301+
allow_fragments=False)
302+
else:
303+
url = self.resolution_scope.url
299304

300305
try:
301306
document = self.store[url]

0 commit comments

Comments
 (0)