Skip to content

Commit 92ac387

Browse files
committed
WIP: Playing with npm_package_bin but seeing Vue's build error
1 parent 71ae8bc commit 92ac387

File tree

2 files changed

+38
-15
lines changed

2 files changed

+38
-15
lines changed

WORKSPACE

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
workspace(
2+
name = "ogpapp",
3+
managed_directories = {"@client": ["client"]},
4+
)
5+
16
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
27

38
# NOTE: @io_bazel_rules_go must come before @io_bazel_rules_docker

client/BUILD

Lines changed: 33 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,43 @@
1-
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
1+
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary", "npm_package_bin")
2+
load("@npm//@vue/cli-service:index.bzl", "vue_cli_service")
23

3-
nodejs_binary(
4-
name = "vue_cli_service",
5-
entry_point = "@npm//:node_modules/@vue/cli-service/bin/vue-cli-service.js",
6-
node_modules = "@npm//:node_modules",
7-
)
4+
#nodejs_binary(
5+
# name = "vue_cli_service",
6+
# entry_point = "@npm//:node_modules/@vue/cli-service/bin/vue-cli-service.js",
7+
# node_modules = "@npm//:node_modules",
8+
#)
89

910
filegroup(
1011
name = "ogpapp_client_src",
1112
srcs = glob([
12-
"src/**/*",
13-
"public/*"
13+
"public/*",
14+
"src/assets/*",
15+
"src/components/*",
16+
"src/router/*",
17+
"src/store/*",
18+
"src/views/*",
19+
"src/*",
1420
]),
1521
)
1622

17-
genrule(
18-
name = "ogpapp_client",
19-
srcs = [
20-
":ogpapp_client_src",
23+
# `npm_package_bin` enables to run arbitrary executables under `node_modules/.bin`
24+
# ref. https://github.com/bazelbuild/rules_nodejs/blob/1.4.1/internal/node/npm_package_bin.bzl#L70-L132
25+
vue_cli_service(
26+
name = "ogpapp_client_build",
27+
args = [
28+
"build",
29+
"--modern",
30+
],
31+
data = glob([
32+
"public/*",
33+
"src/assets/*",
34+
"src/components/*",
35+
"src/router/*",
36+
"src/store/*",
37+
"src/views/*",
38+
"src/*",
39+
]) + [
40+
"@npm//:node_modules",
2141
],
22-
outs = ["dist"],
23-
cmd = "@npm//:node_modules/@vue/cli-service/bin/vue_cli_service.js build",
24-
tools = [":vue_cli_service"],
42+
output_dir = True,
2543
)

0 commit comments

Comments
 (0)