Skip to content

Commit f5b7336

Browse files
agriyakhetarpaljaracoAvasam
authored
Add review suggestions around code comments
Co-authored-by: Jason R. Coombs <[email protected]> Co-authored-by: Avasam <[email protected]>
1 parent 2930193 commit f5b7336

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

distutils/extension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def __init__(
109109
if not isinstance(name, str):
110110
raise AssertionError("'name' must be a string") # noqa: TRY004
111111

112-
# we handle the string case first; though strings are iterable, we disallow them
112+
# handle the string case first; since strings are iterable, disallow them
113113
if isinstance(sources, str):
114114
raise AssertionError( # noqa: TRY004
115115
"'sources' must be an iterable of strings or PathLike objects, not a string"

distutils/tests/test_extension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def test_extension_init(self):
6969
assert ext.name == 'name'
7070

7171
# the second argument, which is the list of files, must
72-
# be a list of strings or PathLike objects, and not a string
72+
# be an iterable of strings or PathLike objects, and not a string
7373
with pytest.raises(AssertionError):
7474
Extension('name', 'file')
7575
with pytest.raises(AssertionError):

0 commit comments

Comments
 (0)