Skip to content

Commit b0f732b

Browse files
committed
Convert QualityChooser test to async test
vuejs/vue-test-utils#1137
1 parent bedb7b0 commit b0f732b

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

themes-default/slim/test/specs/quality-chooser.spec.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ describe('QualityChooser.test.js', () => {
2323
store.replaceState(state);
2424
});
2525

26-
it('renders', () => {
26+
it('renders', async () => {
2727
const { state } = fixtures;
2828
const wrapper = shallowMount(QualityChooser, {
2929
localVue,
3030
store,
31+
sync: false,
3132
propsData: {
3233
overallQuality: undefined,
3334
keep: 'show'
@@ -45,18 +46,21 @@ describe('QualityChooser.test.js', () => {
4546

4647
// If `overallQuality` is provided, `initialQuality` should be that value
4748
wrapper.setProps({ overallQuality: 1000 }); // HD preset
49+
await wrapper.vm.$nextTick();
4850
expect(wrapper.vm.initialQuality).toBe(1000);
4951
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(false);
5052

5153
// Choose a preset
5254
wrapper.setData({ selectedQualityPreset: 6 }); // SD preset
55+
await wrapper.vm.$nextTick();
5356
// Custom quality elements should be hidden
5457
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(false);
5558
expect(wrapper.vm.allowedQualities).toEqual([2, 4]);
5659
expect(wrapper.vm.preferredQualities).toEqual([]);
5760

5861
// Choose custom
5962
wrapper.setData({ selectedQualityPreset: 0 });
63+
await wrapper.vm.$nextTick();
6064
// Custom quality elements should now be visible
6165
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(true);
6266
expect(wrapper.vm.allowedQualities).toEqual([2, 4]);
@@ -67,18 +71,21 @@ describe('QualityChooser.test.js', () => {
6771
selectedQualityPreset: 0,
6872
allowedQualities: []
6973
});
74+
await wrapper.vm.$nextTick();
7075
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(true);
7176
expect(wrapper.findAll('#customQualityWrapper select').at(1).is(':disabled')).toBe(true);
7277

7378
// Choose keep
7479
wrapper.setData({ selectedQualityPreset: 'keep' });
80+
await wrapper.vm.$nextTick();
7581
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(false);
7682
// Underlying value should be equal to `initialQuality`
7783
expect(wrapper.vm.allowedQualities).toEqual([8, 32, 64, 128, 256, 512]); // HD preset
7884
expect(wrapper.vm.preferredQualities).toEqual([]);
7985

8086
// And to custom again
8187
wrapper.setData({ selectedQualityPreset: 0 });
88+
await wrapper.vm.$nextTick();
8289
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(true);
8390
// Underlying value should be equal to `initialQuality`
8491
expect(wrapper.vm.allowedQualities).toEqual([8, 32, 64, 128, 256, 512]); // HD preset
@@ -88,6 +95,7 @@ describe('QualityChooser.test.js', () => {
8895
wrapper.setData({
8996
allowedQualities: [2, 4] // SD preset
9097
});
98+
await wrapper.vm.$nextTick();
9199
expect(wrapper.find('#customQualityWrapper').isVisible()).toBe(true);
92100
expect(wrapper.vm.selectedQualityPreset).toEqual(0);
93101

@@ -97,6 +105,7 @@ describe('QualityChooser.test.js', () => {
97105
preferredQualities: [32]
98106
});
99107
wrapper.setData({ allowedQualities: [] });
108+
await wrapper.vm.$nextTick();
100109
expect(wrapper.findAll('#customQualityWrapper select').at(1).is(':disabled')).toBe(true);
101110
expect(wrapper.vm.allowedQualities).toEqual([]);
102111
expect(wrapper.vm.preferredQualities).toEqual([]);

0 commit comments

Comments
 (0)