Skip to content

Remove list_of_nodes in favor of similar applys_between #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ferrine opened this issue Nov 30, 2022 · 3 comments · Fixed by #776
Closed

Remove list_of_nodes in favor of similar applys_between #65

ferrine opened this issue Nov 30, 2022 · 3 comments · Fixed by #776
Labels
beginner friendly maintenance

Comments

@ferrine
Copy link
Member

ferrine commented Nov 30, 2022 •
edited
Loading

Description

https://github.com/pymc-devs/pytensor/blob/main/pytensor/graph/basic.py#L951
and
https://github.com/pymc-devs/pytensor/blob/main/pytensor/graph/basic.py#L1589
@ricardoV94
Copy link
Member

The second link is pointing to a different function than the one you mentioned list_of_nodes

@ricardoV94 ricardoV94 changed the title list_of_nodes and applys_between seem to do the same thing list_of_nodes and applys_between seem to do the same thing Nov 30, 2022
@ferrine
Copy link
Member Author

ferrine commented Nov 30, 2022

updated

@ricardoV94
Copy link
Member

list_of_nodes is only used in one place and I think it can be safely replaced by the applys_between

@ricardoV94 ricardoV94 changed the title list_of_nodes and applys_between seem to do the same thing Remove list_of_nodes in favor of similar applys_between Dec 7, 2023
@lmmx lmmx mentioned this issue Dec 7, 2023
Closed
@Dhruvanshu-Joshi Dhruvanshu-Joshi mentioned this issue May 19, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove list_of_nodes in favour of applys_between Dhruvanshu-Joshi/pytensor
2 participants
@ferrine @ricardoV94