removed rewrites for slogdet and added the same for det which will be used later

Author: tanish1729

pytensor/tensor/rewriting/linalg.py

@@ -853,39 +853,38 @@ def rewrite_diag_kronecker(fgraph, node):
     return [outer_prod_as_vector]
 
 
-# @register_canonicalize
-# @register_stabilize
-# @node_rewriter([slogdet])
-# def rewrite_slogdet_kronecker(fgraph, node):
-#     """
-#     This rewrite simplifies the slogdet of a kronecker-structured matrix by extracting the individual sub matrices and returning the sign and logdet values computed using those
+@register_canonicalize
+@register_stabilize
+@node_rewriter([det])
+def rewrite_det_kronecker(fgraph, node):
+    """
+    This rewrite simplifies the determinant of a kronecker-structured matrix by extracting the individual sub matrices and returning the det values computed using those
 
-#     Parameters
-#     ----------
-#     fgraph: FunctionGraph
-#         Function graph being optimized
-#     node: Apply
-#         Node of the function graph to be optimized
+    Parameters
+    ----------
+    fgraph: FunctionGraph
+        Function graph being optimized
+    node: Apply
+        Node of the function graph to be optimized
 
-#     Returns
-#     -------
-#     list of Variable, optional
-#         List of optimized variables, or None if no optimization was performed
-#     """
-#     # Check for inner kron operation
-#     potential_kron = node.inputs[0].owner
-#     if not (potential_kron and isinstance(potential_kron.op, KroneckerProduct)):
-#         return None
+    Returns
+    -------
+    list of Variable, optional
+        List of optimized variables, or None if no optimization was performed
+    """
+    # Check for inner kron operation
+    potential_kron = node.inputs[0].owner
+    if not (potential_kron and isinstance(potential_kron.op, KroneckerProduct)):
+        return None
 
-#     # Find the matrices
-#     a, b = potential_kron.inputs
-#     signs, logdets = zip(*[slogdet(a), slogdet(b)])
-#     sizes = [a.shape[-1], b.shape[-1]]
-#     prod_sizes = prod(sizes, no_zeros_in_input=True)
-#     signs_final = [signs[i] ** (prod_sizes / sizes[i]) for i in range(2)]
-#     logdet_final = [logdets[i] * prod_sizes / sizes[i] for i in range(2)]
+    # Find the matrices
+    a, b = potential_kron.inputs
+    dets = [det(a), det(b)]
+    sizes = [a.shape[-1], b.shape[-1]]
+    prod_sizes = prod(sizes, no_zeros_in_input=True)
+    det_final = prod([dets[i] ** (prod_sizes / sizes[i]) for i in range(2)])
 
-#     return [prod(signs_final, no_zeros_in_input=True), sum(logdet_final)]
+    return [det_final]
 
 
 @register_canonicalize

tests/tensor/rewriting/test_linalg.py

@@ -776,11 +776,11 @@ def test_diag_kronecker_rewrite():
     )
 
 
-def test_slogdet_kronecker_rewrite():
+def test_det_kronecker_rewrite():
     a, b = pt.dmatrices("a", "b")
     kron_prod = pt.linalg.kron(a, b)
-    sign_output, logdet_output = pt.linalg.slogdet(kron_prod)
-    f_rewritten = function([kron_prod], [sign_output, logdet_output], mode="FAST_RUN")
+    det_output = pt.linalg.det(kron_prod)
+    f_rewritten = function([kron_prod], [det_output], mode="FAST_RUN")
 
     # Rewrite Test
     nodes = f_rewritten.maker.fgraph.apply_nodes
@@ -789,17 +789,11 @@ def test_slogdet_kronecker_rewrite():
     # Value Test
     a_test, b_test = np.random.rand(2, 20, 20)
     kron_prod_test = np.kron(a_test, b_test)
-    sign_output_test, logdet_output_test = np.linalg.slogdet(kron_prod_test)
-    rewritten_sign_val, rewritten_logdet_val = f_rewritten(kron_prod_test)
+    det_output_test = np.linalg.det(kron_prod_test)
+    rewritten_det_val = f_rewritten(kron_prod_test)
     assert_allclose(
-        sign_output_test,
-        rewritten_sign_val,
-        atol=1e-3 if config.floatX == "float32" else 1e-8,
-        rtol=1e-3 if config.floatX == "float32" else 1e-8,
-    )
-    assert_allclose(
-        logdet_output_test,
-        rewritten_logdet_val,
+        det_output_test,
+        rewritten_det_val,
         atol=1e-3 if config.floatX == "float32" else 1e-8,
         rtol=1e-3 if config.floatX == "float32" else 1e-8,
     )