Added pytest Future Warning in relavant tests

Author: Dhruvanshu-Joshi

pytensor/graph/basic.py

@@ -451,6 +451,12 @@ def __init__(
 
         self.tag = ValidatingScratchpad("test_value", type.filter)
 
+        if hasattr(self.tag, "test_value"):
+            warnings.warn(
+                "test_value machinery is deprecated and will stop working in the future.",
+                FutureWarning,
+            )
+
         self.type = type
 
         self._owner = owner
@@ -479,10 +485,7 @@ def get_test_value(self):
         if not hasattr(self.tag, "test_value"):
             detailed_err_msg = get_variable_trace_string(self)
             raise TestValueError(f"{self} has no test value {detailed_err_msg}")
-        warnings.warn(
-            "test_value machinery is deprecated and will stop working in the future.",
-            FutureWarning,
-        )
+
         return self.tag.test_value
 
     def __str__(self):

pytensor/graph/utils.py

@@ -1,6 +1,7 @@
 import linecache
 import sys
 import traceback
+import warnings
 from abc import ABCMeta
 from collections.abc import Sequence
 from io import StringIO
@@ -283,9 +284,19 @@ def info(self):
 
     # These two methods have been added to help Mypy
     def __getattribute__(self, name):
+        if name == "test_value":
+            warnings.warn(
+                "test_value machinery is deprecated and will stop working in the future.",
+                FutureWarning,
+            )
         return super().__getattribute__(name)
 
     def __setattr__(self, name: str, value: Any) -> None:
+        if name == "test_value":
+            warnings.warn(
+                "test_value machinery is deprecated and will stop working in the future.",
+                FutureWarning,
+            )
         self.__dict__[name] = value
 
 
@@ -300,6 +311,11 @@ def __init__(self, attr, attr_filter):
 
     def __setattr__(self, attr, obj):
         if getattr(self, "attr", None) == attr:
+            if attr == "test_value":
+                warnings.warn(
+                    "test_value machinery is deprecated and will stop working in the future.",
+                    FutureWarning,
+                )
             obj = self.attr_filter(obj)
 
         return object.__setattr__(self, attr, obj)

tests/compile/test_builders.py

@@ -523,11 +523,12 @@ def test_infer_shape(self):
 
     @config.change_flags(compute_test_value="raise")
     def test_compute_test_value(self):
-        x = scalar("x")
-        x.tag.test_value = np.array(1.0, dtype=config.floatX)
-        op = OpFromGraph([x], [x**3])
-        y = scalar("y")
-        y.tag.test_value = np.array(1.0, dtype=config.floatX)
+        with pytest.warns(FutureWarning):
+            x = scalar("x")
+            x.tag.test_value = np.array(1.0, dtype=config.floatX)
+            op = OpFromGraph([x], [x**3])
+            y = scalar("y")
+            y.tag.test_value = np.array(1.0, dtype=config.floatX)
         f = op(y)
         grad_f = grad(f, y)
         assert grad_f.tag.test_value is not None

tests/compile/test_ops.py

@@ -1,6 +1,7 @@
 import pickle
 
 import numpy as np
+import pytest
 
 from pytensor import function
 from pytensor.compile.ops import as_op
@@ -32,10 +33,11 @@ def cumprod(x):
         assert np.allclose(r, r0), (r, r0)
 
     def test_2arg(self):
-        x = dmatrix("x")
-        x.tag.test_value = np.zeros((2, 2))
-        y = dvector("y")
-        y.tag.test_value = [0, 0, 0, 0]
+        with pytest.warns(FutureWarning):
+            x = dmatrix("x")
+            x.tag.test_value = np.zeros((2, 2))
+            y = dvector("y")
+            y.tag.test_value = [0, 0, 0, 0]
 
         @as_op([dmatrix, dvector], dvector)
         def cumprod_plus(x, y):
@@ -48,10 +50,11 @@ def cumprod_plus(x, y):
         assert np.allclose(r, r0), (r, r0)
 
     def test_infer_shape(self):
-        x = dmatrix("x")
-        x.tag.test_value = np.zeros((2, 2))
-        y = dvector("y")
-        y.tag.test_value = [0, 0, 0, 0]
+        with pytest.warns(FutureWarning):
+            x = dmatrix("x")
+            x.tag.test_value = np.zeros((2, 2))
+            y = dvector("y")
+            y.tag.test_value = [0, 0, 0, 0]
 
         def infer_shape(fgraph, node, shapes):
             x, y = shapes

tests/graph/test_compute_test_value.py

@@ -67,7 +67,8 @@ def perform(self, node, inputs, outputs):
 
         test_input = SomeType()()
         orig_object = object()
-        test_input.tag.test_value = orig_object
+        with pytest.warns(FutureWarning):
+            test_input.tag.test_value = orig_object
 
         res = InplaceOp(False)(test_input)
         assert res.tag.test_value is orig_object
@@ -76,10 +77,11 @@ def perform(self, node, inputs, outputs):
         assert res.tag.test_value is not orig_object
 
     def test_variable_only(self):
-        x = matrix("x")
-        x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
-        y = matrix("y")
-        y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            x = matrix("x")
+            x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
+            y = matrix("y")
+            y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
 
         # should work
         z = dot(x, y)
@@ -88,14 +90,16 @@ def test_variable_only(self):
         assert _allclose(f(x.tag.test_value, y.tag.test_value), z.tag.test_value)
 
         # this test should fail
-        y.tag.test_value = np.random.random((6, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            y.tag.test_value = np.random.random((6, 5)).astype(config.floatX)
         with pytest.raises(ValueError):
             dot(x, y)
 
     def test_compute_flag(self):
         x = matrix("x")
         y = matrix("y")
-        y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
 
         # should skip computation of test value
         with config.change_flags(compute_test_value="off"):
@@ -111,10 +115,11 @@ def test_compute_flag(self):
             dot(x, y)
 
     def test_string_var(self):
-        x = matrix("x")
-        x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
-        y = matrix("y")
-        y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            x = matrix("x")
+            x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
+            y = matrix("y")
+            y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
 
         z = pytensor.shared(np.random.random((5, 6)).astype(config.floatX))
 
@@ -134,7 +139,8 @@ def f(x, y, z):
 
     def test_shared(self):
         x = matrix("x")
-        x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
         y = pytensor.shared(np.random.random((4, 6)).astype(config.floatX), "y")
 
         # should work
@@ -189,31 +195,34 @@ def test_constant(self):
 
     def test_incorrect_type(self):
         x = vector("x")
-        with pytest.raises(TypeError):
+        with pytest.raises(TypeError) and pytest.warns(FutureWarning):
             # Incorrect shape for test value
             x.tag.test_value = np.empty((2, 2))
 
         x = fmatrix("x")
-        with pytest.raises(TypeError):
+        with pytest.raises(TypeError) and pytest.warns(FutureWarning):
             # Incorrect dtype (float64) for test value
             x.tag.test_value = np.random.random((3, 4))
 
     def test_overided_function(self):
         # We need to test those as they mess with Exception
         # And we don't want the exception to be changed.
-        x = matrix()
-        x.tag.test_value = np.zeros((2, 3), dtype=config.floatX)
-        y = matrix()
-        y.tag.test_value = np.zeros((2, 2), dtype=config.floatX)
+
+        with pytest.warns(FutureWarning):
+            x = matrix()
+            x.tag.test_value = np.zeros((2, 3), dtype=config.floatX)
+            y = matrix()
+            y.tag.test_value = np.zeros((2, 2), dtype=config.floatX)
         with pytest.raises(ValueError):
             x.__mul__(y)
 
     def test_scan(self):
         # Test the compute_test_value mechanism Scan.
         k = iscalar("k")
         A = vector("A")
-        k.tag.test_value = 3
-        A.tag.test_value = np.random.random((5,)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            k.tag.test_value = 3
+            A.tag.test_value = np.random.random((5,)).astype(config.floatX)
 
         def fx(prior_result, A):
             return prior_result * A
@@ -233,8 +242,9 @@ def test_scan_err1(self):
         # This test should fail when building fx for the first time
         k = iscalar("k")
         A = matrix("A")
-        k.tag.test_value = 3
-        A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            k.tag.test_value = 3
+            A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
 
         def fx(prior_result, A):
             return dot(prior_result, A)
@@ -253,8 +263,9 @@ def test_scan_err2(self):
         # but when calling the scan's perform()
         k = iscalar("k")
         A = matrix("A")
-        k.tag.test_value = 3
-        A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            k.tag.test_value = 3
+            A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
 
         def fx(prior_result, A):
             return dot(prior_result, A)
@@ -288,7 +299,8 @@ def perform(self, node, inputs, outputs):
                 output[0] = input + 1
 
         i = ps.int32("i")
-        i.tag.test_value = 3
+        with pytest.warns(FutureWarning):
+            i.tag.test_value = 3
 
         o = IncOnePython()(i)
 
@@ -304,7 +316,8 @@ def perform(self, node, inputs, outputs):
     )
     def test_no_perform(self):
         i = ps.int32("i")
-        i.tag.test_value = 3
+        with pytest.warns(FutureWarning):
+            i.tag.test_value = 3
 
         # Class IncOneC is defined outside of the TestComputeTestValue
         # so it can be pickled and unpickled

tests/graph/test_fg.py

@@ -232,18 +232,19 @@ def test_change_input(self):
 
     @config.change_flags(compute_test_value="raise")
     def test_replace_test_value(self):
-        var1 = MyVariable("var1")
-        var1.tag.test_value = 1
-        var2 = MyVariable("var2")
-        var2.tag.test_value = 2
-        var3 = op1(var2, var1)
-        var4 = op2(var3, var2)
-        var4.tag.test_value = np.array([1, 2])
-        var5 = op3(var4, var2, var2)
-        fg = FunctionGraph([var1, var2], [var3, var5], clone=False)
-
-        var6 = op3()
-        var6.tag.test_value = np.array(0)
+        with pytest.warns(FutureWarning):
+            var1 = MyVariable("var1")
+            var1.tag.test_value = 1
+            var2 = MyVariable("var2")
+            var2.tag.test_value = 2
+            var3 = op1(var2, var1)
+            var4 = op2(var3, var2)
+            var4.tag.test_value = np.array([1, 2])
+            var5 = op3(var4, var2, var2)
+            fg = FunctionGraph([var1, var2], [var3, var5], clone=False)
+
+            var6 = op3()
+            var6.tag.test_value = np.array(0)
 
         assert var6.tag.test_value.shape != var4.tag.test_value.shape
 

tests/graph/test_op.py

@@ -131,34 +131,39 @@ def perform(self, node, inputs, outputs):
 
 
 def test_test_value_python_objects():
-    for x in ([0, 1, 2], 0, 0.5, 1):
-        assert np.all(op.get_test_value(x) == x)
+    with pytest.warns(FutureWarning):
+        for x in ([0, 1, 2], 0, 0.5, 1):
+            assert np.all(op.get_test_value(x) == x)
 
 
 def test_test_value_ndarray():
     x = np.zeros((5, 5))
-    v = op.get_test_value(x)
+    with pytest.warns(FutureWarning):
+        v = op.get_test_value(x)
     assert np.all(v == x)
 
 
 def test_test_value_constant():
     x = pt.as_tensor_variable(np.zeros((5, 5)))
-    v = op.get_test_value(x)
+    with pytest.warns(FutureWarning):
+        v = op.get_test_value(x)
 
     assert np.all(v == np.zeros((5, 5)))
 
 
 def test_test_value_shared():
     x = shared(np.zeros((5, 5)))
-    v = op.get_test_value(x)
+    with pytest.warns(FutureWarning):
+        v = op.get_test_value(x)
 
     assert np.all(v == np.zeros((5, 5)))
 
 
 @config.change_flags(compute_test_value="raise")
 def test_test_value_op():
     x = log(np.ones((5, 5)))
-    v = op.get_test_value(x)
+    with pytest.warns(FutureWarning):
+        v = op.get_test_value(x)
 
     assert np.allclose(v, np.zeros((5, 5)))
 
@@ -168,22 +173,26 @@ def test_get_test_values_no_debugger():
     """Tests that `get_test_values` returns `[]` when debugger is off."""
 
     x = vector()
-    assert op.get_test_values(x) == []
+    with pytest.warns(FutureWarning):
+        assert op.get_test_values(x) == []
 
 
 @config.change_flags(compute_test_value="ignore")
 def test_get_test_values_ignore():
     """Tests that `get_test_values` returns `[]` when debugger is set to "ignore" and some values are missing."""
 
     x = vector()
-    assert op.get_test_values(x) == []
+    with pytest.warns(FutureWarning):
+        assert op.get_test_values(x) == []
 
 
 def test_get_test_values_success():
     """Tests that `get_test_values` returns values when available (and the debugger is on)."""
 
     for mode in ["ignore", "warn", "raise"]:
-        with config.change_flags(compute_test_value=mode):
+        with config.change_flags(compute_test_value=mode) and pytest.warns(
+            FutureWarning
+        ):
             x = vector()
             x.tag.test_value = np.zeros((4,), dtype=config.floatX)
             y = np.zeros((5, 5))
@@ -203,7 +212,7 @@ def test_get_test_values_success():
 def test_get_test_values_exc():
     """Tests that `get_test_values` raises an exception when debugger is set to raise and a value is missing."""
 
-    with pytest.raises(TestValueError):
+    with pytest.raises(TestValueError) and pytest.warns(FutureWarning):
         x = vector()
         assert op.get_test_values(x) == []