run_mypy script failing (due to new Pandas behavior?)

[ricardoV94]

Description

https://github.com/pymc-devs/pymc/actions/runs/6406798422/job/17392150214?pr=6933

[ricardoV94]

CC @michaelosthege

[michaelosthege]

Sounds like failing = set(df.reset_index().file.str.replace(os.sep, "/", regex=False)) has non-str types in the file column.

Can you try replacing the line by this?

failing = set(df.reset_index()["file"].astype(str).str.replace(os.sep, "/", regex=False))

[ricardoV94]

Didn't make the trick :)

This is good news! Go to scripts/run_mypy.py and remove them from the `FAILING` list.
WOW! All files are passing the mypy type checks!

I doubt so, but the dataframe is indeed empty so probably mypy run is just failing and we don't raise when the subprocess fails

[ricardoV94]

Also why are we pinned to mypy 0.99?

[ricardoV94]

Getting a mysterious AssertionError: Error checking function redefinition

Traceback: https://github.com/pymc-devs/pymc/actions/runs/6431546082/job/17464665779?pr=6942#step:7:15

[michaelosthege]

Also why are we pinned to mypy 0.99?

Simply put we're pinned because our dependabot only cares about GitHub actions

Locally I can't reproduce this problem

[ricardoV94]

Locally I can't reproduce this problem

Me neither. Probably a specific dependency version