Skip to content

Replace custom RandomVariable for WeibullBetaRV #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ricardoV94 opened this issue May 11, 2021 · 2 comments
Closed

Replace custom RandomVariable for WeibullBetaRV #4683

ricardoV94 opened this issue May 11, 2021 · 2 comments
Labels
v4

Comments

@ricardoV94
Copy link
Member

Reminder issue to remove the RandomVariable for WeibullBetaRV (introduced in #4640) once we have the automatic multiplication logp working (e.g., #4653)
@ricardoV94 ricardoV94 added the v4 label May 11, 2021
This was referenced May 11, 2021
Merged
Merged
@brandonwillard
Copy link
Contributor

We might be able to use aesara.compile.builders.OpFromGraph in the interim. OpFromGraph will create a new Op to which we can assign a _logp specialization. This removes the need to create a RandomVariable Op for cases in which operations that are already covered by existing Ops are applied to existing RandomVariables.

@michaelosthege michaelosthege added this to the vNext (4.0.0) milestone Jun 5, 2021
@ricardoV94
Copy link
Member Author

ricardoV94 commented Jun 27, 2021 •
edited
Loading

Same for the Wald which is just the numpy offering + optional shifting. #4711

@ricardoV94 ricardoV94 removed this from the vNext (4.0.0) milestone Jun 27, 2021
@ricardoV94 ricardoV94 closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brandonwillard @michaelosthege @ricardoV94