Skip to content

Pyflakes and pycodestyle return many warnings #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canyon289 opened this issue Jun 27, 2018 · 1 comment
Closed

Pyflakes and pycodestyle return many warnings #3063

canyon289 opened this issue Jun 27, 2018 · 1 comment

Comments

@canyon289
Copy link
Member

canyon289 commented Jun 27, 2018

Hello,
The contributing guide mention using pyflakes and pycodestyle to check for warnings in the codebase

When I run this though on the master branch I get a lot of warnings.

Is my output correct? If so should these be resolved per the contributing guide?

The warnings I get are attached below
pycodestyle_warnings.txt
pyflakes_warnings.txt

@eigenfoo
Copy link
Member

Referring to #3307 (comment) and #3239 (comment).

The tldr is that, since refactoring code for style would touch many lines in the code base, a simple git blame would not come up with anything useful. By all means we should write pep8-comformant code going forward, but touching everything to conform to PEP8 is a bit extreme.

Closing this issue now, but please reopen if you have something to add!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants