Skip to content

Commit ed9a60a

Browse files
OriolAbrilmichaelosthege
authored andcommitted
Update to ArviZ 0.11.4 and fix tests
The changes from 33dd132 (probably unpinning NumPy) fixed `test_wald_logcdf` and broke `test_negative_binomial`.
1 parent 33dd132 commit ed9a60a

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

conda-envs/environment-dev-py37.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ channels:
44
- defaults
55
dependencies:
66
- aesara>=2.1.0
7-
- arviz>=0.11.2
7+
- arviz>=0.11.4
88
- cachetools>=4.2.1
99
- cloudpickle
1010
- fastprogress>=0.2.0

conda-envs/environment-dev-py38.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ channels:
44
- defaults
55
dependencies:
66
- aesara>=2.1.0
7-
- arviz>=0.11.2
7+
- arviz>=0.11.4
88
- cachetools>=4.2.1
99
- cloudpickle
1010
- fastprogress>=0.2.0

conda-envs/environment-dev-py39.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ channels:
44
- defaults
55
dependencies:
66
- aesara>=2.1.0
7-
- arviz>=0.11.2
7+
- arviz>=0.11.4
88
- cachetools>=4.2.1
99
- cloudpickle
1010
- fastprogress>=0.2.0

conda-envs/windows-environment-dev-py38.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ channels:
55
dependencies:
66
# base dependencies (see install guide for Windows)
77
- aesara>=2.1.0
8-
- arviz>=0.11.2
8+
- arviz>=0.11.4
99
- cachetools>=4.2.1
1010
- cloudpickle
1111
- fastprogress>=0.2.0

pymc/tests/test_distributions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,10 +1114,6 @@ def test_wald_logp(self):
11141114
decimal=select_by_precision(float64=6, float32=1),
11151115
)
11161116

1117-
@pytest.mark.xfail(
1118-
condition=(aesara.config.floatX == "float32"),
1119-
reason="Poor CDF in SciPy. See scipy/scipy#869 for details.",
1120-
)
11211117
def test_wald_logcdf(self):
11221118
self.check_logcdf(
11231119
Wald,
@@ -1273,6 +1269,10 @@ def modified_scipy_hypergeom_logcdf(value, N, k, n):
12731269
{"N": NatSmall, "k": NatSmall, "n": NatSmall},
12741270
)
12751271

1272+
@pytest.mark.xfail(
1273+
condition=(aesara.config.floatX == "float32"),
1274+
reason="SciPy log CDF stopped working after un-pinning NumPy version.",
1275+
)
12761276
def test_negative_binomial(self):
12771277
def scipy_mu_alpha_logpmf(value, mu, alpha):
12781278
return sp.nbinom.logpmf(value, alpha, 1 - mu / (mu + alpha))

requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# See that file for comments about the need/usage of each dependency.
33

44
aesara>=2.1.0
5-
arviz>=0.11.2
5+
arviz>=0.11.4
66
cachetools>=4.2.1
77
cloudpickle
88
fastprogress>=0.2.0

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
aesara>=2.1.0
2-
arviz>=0.11.2
2+
arviz>=0.11.4
33
cachetools>=4.2.1
44
cloudpickle
55
fastprogress>=0.2.0

0 commit comments

Comments
 (0)