Skip to content

Commit e6cd229

Browse files
kyleabeauchamptwiecki
authored andcommitted
Use better name for helper function
1 parent e31b45f commit e6cd229

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pymc3/tests/test_distributions.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import scipy.stats
2828

2929

30-
def select_decimal(float64, float32):
30+
def select_by_precision(float64, float32):
3131
"""Helper function to choose reasonable decimal cutoffs for different floatX modes."""
3232
decimal = float64 if theano.config.floatX == "float64" else float32
3333
return decimal
@@ -314,7 +314,7 @@ def check_logp(self, model, value, domain, paramdomains, logp_reference):
314314
logp = model.fastlogp
315315
for pt in product(domains, n_samples=100):
316316
pt = Point(pt, model=model)
317-
assert_almost_equal(logp(pt), logp_reference(pt), decimal=select_decimal(float64=6, float32=2), err_msg=str(pt))
317+
assert_almost_equal(logp(pt), logp_reference(pt), decimal=select_by_precision(float64=6, float32=2), err_msg=str(pt))
318318

319319
def check_int_to_1(self, model, value, domain, paramdomains):
320320
pdf = model.fastfn(exp(model.logpt))
@@ -350,7 +350,7 @@ def wrapped_logp(x):
350350
for pt in product(domains, n_samples=100):
351351
pt = Point(pt, model=model)
352352
pt = bij.map(pt)
353-
assert_almost_equal(dlogp(pt), ndlogp(pt), decimal=select_decimal(float64=6, float32=4), err_msg=str(pt))
353+
assert_almost_equal(dlogp(pt), ndlogp(pt), decimal=select_by_precision(float64=6, float32=4), err_msg=str(pt))
354354

355355
def checkd(self, distfam, valuedomain, vardomains, checks=None, extra_args={}):
356356
if checks is None:
@@ -423,7 +423,7 @@ def test_wald(self, value, mu, lam, phi, alpha, logp):
423423
with Model() as model:
424424
Wald('wald', mu=mu, lam=lam, phi=phi, alpha=alpha, transform=None)
425425
pt = {'wald': value}
426-
assert_almost_equal(model.fastlogp(pt), logp, decimal=select_decimal(float64=6, float32=1), err_msg=str(pt))
426+
assert_almost_equal(model.fastlogp(pt), logp, decimal=select_by_precision(float64=6, float32=1), err_msg=str(pt))
427427

428428
def test_beta(self):
429429
self.pymc3_matches_scipy(Beta, Unit, {'alpha': Rplus, 'beta': Rplus},
@@ -567,7 +567,7 @@ def test_lkj(self, x, n, p, lp):
567567
LKJCorr('lkj', n=n, p=p, transform=None)
568568

569569
pt = {'lkj': x}
570-
assert_almost_equal(model.fastlogp(pt), lp, decimal=select_decimal(float64=6, float32=4), err_msg=str(pt))
570+
assert_almost_equal(model.fastlogp(pt), lp, decimal=select_by_precision(float64=6, float32=4), err_msg=str(pt))
571571

572572
@parameterized.expand([(2,), (3,)])
573573
def test_dirichlet(self, n):

0 commit comments

Comments
 (0)