Skip to content

Commit 966aabf

Browse files
authored
Bump Aesara to 2.7.5, aeppl to 0.0.32, update tests for aeppl (#5955)
* Bump Aesara to v2.7.5 * Bump aeppl to v0.0.32 * Revert warn_missing_rvs to default value of True See #5955 (comment) This adapts to the change in behavior introduced in aesara-devs/aeppl#151.
1 parent 294ff4a commit 966aabf

File tree

9 files changed

+26
-19
lines changed

9 files changed

+26
-19
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ repos:
2626
- types-filelock
2727
- types-setuptools
2828
- arviz
29-
- aesara==2.7.3
30-
- aeppl==0.0.31
29+
- aesara==2.7.5
30+
- aeppl==0.0.32
3131
always_run: true
3232
require_serial: true
3333
pass_filenames: false

conda-envs/environment-dev.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ channels:
55
- defaults
66
dependencies:
77
# Base dependencies
8-
- aeppl=0.0.31
9-
- aesara=2.7.4
8+
- aeppl=0.0.32
9+
- aesara=2.7.5
1010
- arviz>=0.12.0
1111
- blas
1212
- cachetools>=4.2.1

conda-envs/environment-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ channels:
55
- defaults
66
dependencies:
77
# Base dependencies
8-
- aeppl=0.0.31
9-
- aesara=2.7.4
8+
- aeppl=0.0.32
9+
- aesara=2.7.5
1010
- arviz>=0.12.0
1111
- blas
1212
- cachetools>=4.2.1

conda-envs/windows-environment-dev.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ channels:
55
- defaults
66
dependencies:
77
# Base dependencies (see install guide for Windows)
8-
- aeppl=0.0.31
9-
- aesara=2.7.4
8+
- aeppl=0.0.32
9+
- aesara=2.7.5
1010
- arviz>=0.12.0
1111
- blas
1212
- cachetools>=4.2.1

conda-envs/windows-environment-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ channels:
55
- defaults
66
dependencies:
77
# Base dependencies (see install guide for Windows)
8-
- aeppl=0.0.31
9-
- aesara=2.7.4
8+
- aeppl=0.0.32
9+
- aesara=2.7.5
1010
- arviz>=0.12.0
1111
- blas
1212
- cachetools>=4.2.1

pymc/distributions/logprob.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,6 @@ def joint_logp(
236236
tmp_rvs_to_values,
237237
extra_rewrites=transform_opt,
238238
use_jacobian=jacobian,
239-
warn_missing_rvs=False,
240239
**kwargs,
241240
)
242241

pymc/tests/test_logprob.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14+
import warnings
15+
1416
import aesara
1517
import aesara.tensor as at
1618
import numpy as np
@@ -333,11 +335,17 @@ def logp(value, x):
333335
with Model() as m:
334336
x = Normal.dist()
335337
y = DensityDist("y", x, logp=logp)
336-
# Aeppl raises a KeyError when it finds an unexpected RV
337-
with pytest.raises(KeyError):
338-
joint_logp([y], {y: y.type()})
338+
with pytest.warns(
339+
UserWarning,
340+
match="Found a random variable that was neither among the observations "
341+
"nor the conditioned variables",
342+
):
343+
assert joint_logp([y], {y: y.type()})
339344

345+
# The above warning should go away with ignore_logprob.
340346
with Model() as m:
341347
x = ignore_logprob(Normal.dist())
342348
y = DensityDist("y", x, logp=logp)
343-
assert joint_logp([y], {y: y.type()})
349+
with warnings.catch_warnings():
350+
warnings.simplefilter("error")
351+
assert joint_logp([y], {y: y.type()})

requirements-dev.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# This file is auto-generated by scripts/generate_pip_deps_from_conda.py, do not modify.
22
# See that file for comments about the need/usage of each dependency.
33

4-
aeppl==0.0.31
5-
aesara==2.7.4
4+
aeppl==0.0.32
5+
aesara==2.7.5
66
arviz>=0.12.0
77
cachetools>=4.2.1
88
cloudpickle

requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
aeppl==0.0.31
2-
aesara==2.7.4
1+
aeppl==0.0.32
2+
aesara==2.7.5
33
arviz>=0.12.0
44
cachetools>=4.2.1
55
cloudpickle

0 commit comments

Comments
 (0)