Fix pylint and pre-commit (#5128)

* Fix pylint config
* Fix pre-commit

Author: ferrine

.pre-commit-config.yaml

@@ -1,4 +1,4 @@
-exclude: ^(docs/logos|pymc3/tests/data)/
+exclude: ^(docs/logos|pymc/tests/data)/
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
   rev: v4.0.1
@@ -32,12 +32,12 @@ repos:
   hooks:
     - id: pylint
       args: [--rcfile=.pylintrc]
-      files: ^pymc3/
+      files: ^pymc/
 - repo: https://github.com/MarcoGorelli/madforhooks
   rev: 0.2.1
   hooks:
     - id: no-print-statements
-      files: ^pymc3/
+      files: ^pymc/
     - id: conda-env-sorter
       files: ^conda-envs/environment-dev-py.+\.yml$
 - repo: local

pymc/__init__.py

@@ -32,7 +32,7 @@ def _check_install_compatibilitites():
     try:
         import theano
 
-        print(
+        _log.warning(
             "!" * 60
             + f"\nYour Python environment has Theano(-PyMC) {theano.__version__} installed, "
             + f"but you are importing PyMC {__version__} which uses Aesara as its backend."
@@ -46,7 +46,7 @@ def _check_install_compatibilitites():
     try:
         import pymc3
 
-        print(
+        _log.warning(
             "!" * 60
             + f"\nYou are importing PyMC {__version__}, but your environment also has"
             + f" the legacy version PyMC3 {pymc3.__version__} installed."

pymc/backends/ndarray.py

@@ -16,7 +16,6 @@
 
 Store sampling values in memory as a NumPy array.
 """
-import glob
 import json
 import os
 import shutil

pymc/distributions/distribution.py

@@ -22,7 +22,6 @@
 from typing import Callable, Optional, Sequence
 
 import aesara
-import numpy as np
 
 from aeppl.logprob import _logprob
 from aesara.tensor.basic import as_tensor_variable
@@ -43,7 +42,6 @@
     maybe_resize,
     resize_from_dims,
     resize_from_observed,
-    to_tuple,
 )
 from pymc.printing import str_for_dist
 from pymc.util import UNSET

pymc/model.py

@@ -38,8 +38,6 @@
 import numpy as np
 import scipy.sparse as sps
 
-from aeppl.transforms import RVTransform
-from aesara.compile.mode import Mode, get_mode
 from aesara.compile.sharedvalue import SharedVariable
 from aesara.graph.basic import Constant, Variable, graph_inputs
 from aesara.graph.fg import FunctionGraph

pymc/sampling.py

@@ -22,7 +22,7 @@
 import warnings
 
 from collections import defaultdict
-from copy import copy, deepcopy
+from copy import copy
 from typing import Dict, Iterable, List, Optional, Sequence, Set, Tuple, Union, cast
 
 import aesara.gradient as tg
@@ -51,7 +51,7 @@
     filter_rvs_to_jitter,
     make_initial_point_fns_per_chain,
 )
-from pymc.model import Model, Point, modelcontext
+from pymc.model import Model, modelcontext
 from pymc.parallel_sampling import Draw, _cpu_count
 from pymc.step_methods import (
     NUTS,

pymc/step_methods/mlda.py

@@ -17,15 +17,13 @@
 
 from typing import Any, Dict, List, Optional, Tuple, Type, Union
 
-import aesara
 import arviz as az
 import numpy as np
 
 from aesara.tensor.sharedvar import TensorSharedVariable
 
 import pymc as pm
 
-from pymc.aesaraf import compile_rv_inplace
 from pymc.blocking import DictToArrayBijection, RaveledVars
 from pymc.model import Model, Point
 from pymc.step_methods.arraystep import ArrayStepShared, Competence, metrop_select

pymc/tests/test_distributions_random.py

@@ -37,7 +37,6 @@ def random_polyagamma(*args, **kwargs):
         raise RuntimeError("polyagamma package is not installed!")
 
 
-from aeppl.logprob import _logprob
 from scipy.special import expit
 
 import pymc as pm

pymc/tests/test_logprob.py

@@ -17,9 +17,7 @@
 import pytest
 import scipy.stats.distributions as sp
 
-from aesara.gradient import DisconnectedGrad
-from aesara.graph.basic import Constant, ancestors, graph_inputs
-from aesara.graph.fg import FunctionGraph
+from aesara.graph.basic import ancestors
 from aesara.tensor.random.op import RandomVariable
 from aesara.tensor.subtensor import (
     AdvancedIncSubtensor,

pymc/tests/test_model.py

@@ -28,7 +28,6 @@
 
 from aesara.tensor.random.op import RandomVariable
 from aesara.tensor.var import TensorConstant
-from numpy.testing import assert_almost_equal
 
 import pymc as pm
 

pymc/tests/test_ndarray_backend.py

@@ -16,8 +16,6 @@
 import numpy.testing as npt
 import pytest
 
-import pymc as pm
-
 from pymc.backends import base, ndarray
 from pymc.tests import backend_fixtures as bf
 

pymc/tests/test_step.py

@@ -16,8 +16,6 @@
 import sys
 import tempfile
 
-from math import isclose
-
 import aesara
 import aesara.tensor as at
 import arviz as az

pymc/tests/test_types.py

@@ -16,7 +16,6 @@
 
 import aesara
 import numpy as np
-import pytest
 
 from pymc.distributions import Normal
 from pymc.model import Model