Skip to content

Commit 3ff4959

Browse files
Update releasenotes and apply review feedback
1 parent 7eb78a7 commit 3ff4959

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

RELEASE-NOTES.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
11
# Release Notes
22

3-
## PyMC3 3.10.1 (on deck)
3+
## PyMC3 3.11.0 (on deck)
4+
This release breaks some APIs w.r.t. `3.10.0`.
5+
It also brings some dreadfully awaited fixes, so be sure to go through the changes below.
6+
(Or latest when you run into problems.)
47

58
### Maintenance
9+
- Changed shape behavior: __No longer collapse length 1 vector shape into scalars.__ (see [#4206](https://github.com/pymc-devs/pymc3/issue/4206) and [#4214](https://github.com/pymc-devs/pymc3/pull/4214))
10+
- __Applies to random variables and also the `.random(size=...)` kwarg!__
11+
- To create scalar variables you must now use `shape=None` or `shape=()`.
12+
- __`shape=(1,)` and `shape=1` now become vectors.__ Previously they were collapsed into scalars
13+
- 0-length dimensions are now ruled illegal for random variables and raise a `ValueError`.
614
- Fixed bug whereby partial traces returns after keyboard interrupt during parallel sampling had fewer draws than would've been available [#4318](https://github.com/pymc-devs/pymc3/pull/4318)
715
- Make `sample_shape` same across all contexts in `draw_values` (see [#4305](https://github.com/pymc-devs/pymc3/pull/4305)).
816
- Removed `theanof.set_theano_config` because it illegally touched Theano's privates (see [#4329](https://github.com/pymc-devs/pymc3/pull/4329)).
17+
- In `sample_prior_predictive` the `vars` kwarg was removed in favor of `var_names` (see [#4327](https://github.com/pymc-devs/pymc3/pull/4327))
918

1019

1120
## PyMC3 3.10.0 (7 December 2020)

pymc3/distributions/distribution.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1007,14 +1007,6 @@ def _draw_value(param, point=None, givens=None, size=None):
10071007
raise ValueError("Unexpected type in draw_value: %s" % type(param))
10081008

10091009

1010-
def _is_one_d(dist_shape):
1011-
if hasattr(dist_shape, "dshape") and dist_shape.dshape in {()}:
1012-
return True
1013-
elif hasattr(dist_shape, "shape") and dist_shape.shape in {()}:
1014-
return True
1015-
return False
1016-
1017-
10181010
def generate_samples(generator, *args, **kwargs):
10191011
"""Generate samples from the distribution of a random variable.
10201012
@@ -1048,8 +1040,6 @@ def generate_samples(generator, *args, **kwargs):
10481040
Any remaining args and kwargs are passed on to the generator function.
10491041
"""
10501042
dist_shape = kwargs.pop("dist_shape", ())
1051-
# TODO: the following variable is no longer used !!
1052-
one_d = _is_one_d(dist_shape)
10531043
size = kwargs.pop("size", None)
10541044
broadcast_shape = kwargs.pop("broadcast_shape", None)
10551045
not_broadcast_kwargs = kwargs.pop("not_broadcast_kwargs", None)

0 commit comments

Comments
 (0)