Skip to content

Commit 2ba776c

Browse files
author
Junpeng Lao
committed
Add comment as warning
1 parent af5aace commit 2ba776c

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

pymc3/distributions/transforms.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ def forward(self, x):
137137
return tt.log(x - a) - tt.log(b - x)
138138

139139
def forward_val(self, x, point=None):
140+
# 2017-06-19
141+
# the `self.a-0.` below is important for the testval to propagates
142+
# For an explanation see pull/2328#issuecomment-309303811
140143
a, b = draw_values([self.a-0., self.b-0.],
141144
point=point)
142145
return floatX(tt.log(x - a) - tt.log(b - x))
@@ -166,6 +169,9 @@ def forward(self, x):
166169
return tt.log(x - a)
167170

168171
def forward_val(self, x, point=None):
172+
# 2017-06-19
173+
# the `self.a-0.` below is important for the testval to propagates
174+
# For an explanation see pull/2328#issuecomment-309303811
169175
a = draw_values([self.a-0.],
170176
point=point)[0]
171177
return floatX(tt.log(x - a))
@@ -194,6 +200,9 @@ def forward(self, x):
194200
return tt.log(b - x)
195201

196202
def forward_val(self, x, point=None):
203+
# 2017-06-19
204+
# the `self.b-0.` below is important for the testval to propagates
205+
# For an explanation see pull/2328#issuecomment-309303811
197206
b = draw_values([self.b-0.],
198207
point=point)[0]
199208
return floatX(tt.log(b - x))

0 commit comments

Comments
 (0)