Skip to content

Commit 10c914b

Browse files
michaelosthegericardoV94twiecki
authored
Remove JAX sampling on v3 in favor of v4 (#4866)
* Remove JAX sampling in favor of v4 Closes #4865 * Use newer link Co-authored-by: Ricardo Vieira <[email protected]> * Rephrase Co-authored-by: Thomas Wiecki <[email protected]> Co-authored-by: Ricardo Vieira <[email protected]> Co-authored-by: Thomas Wiecki <[email protected]>
1 parent 9cd79ba commit 10c914b

File tree

7 files changed

+6
-316
lines changed

7 files changed

+6
-316
lines changed

.github/workflows/jaxtests.yml

Lines changed: 0 additions & 64 deletions
This file was deleted.

.github/workflows/pytest.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ jobs:
2727
--ignore=pymc3/tests/test_quadpotential.py
2828
--ignore=pymc3/tests/test_random.py
2929
--ignore=pymc3/tests/test_sampling.py
30-
--ignore=pymc3/tests/test_sampling_jax.py
3130
--ignore=pymc3/tests/test_shape_handling.py
3231
--ignore=pymc3/tests/test_shared.py
3332
--ignore=pymc3/tests/test_smc.py

README.rst

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ The future of PyMC3 & Theano
1919
============================
2020

2121
There have been many questions and uncertainty around the future of PyMC3 since Theano
22-
stopped getting developed by the original authors, and we started experiments with PyMC4.
22+
stopped getting developed by the original authors, and we started experiments with a PyMC version based on tensorflow probability.
2323

24-
We are happy to announce that PyMC3 on Theano (which we are `developing further <https://github.com/pymc-devs/Theano-PyMC>`__)
25-
with a new JAX backend is the future. PyMC4 will not be developed further.
26-
27-
See the `full announcement <https://pymc-devs.medium.com/the-future-of-pymc3-or-theano-is-dead-long-live-theano-d8005f8a0e9b>`__
28-
for more details.
24+
Since then many things changed and we are happy to announce that PyMC3 will continue to rely on Theano,
25+
or rather its successors Theano-PyMC (`pymc3 <4)` and Aesara (`pymc3 >=4`).
26+
Check out <https://github.com/aesara-devs/aesara>`__) and specifically the latest developments on the `PyMC3 `main` branch <https://github.com/pymc-devs/pymc3/>`.
2927

3028
Features
3129
========

RELEASE-NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
+ Generalized BART, bounded distributions like Binomial and Poisson can now be used as likelihoods (see [#4675](https://github.com/pymc-devs/pymc3/pull/4675), [#4709](https://github.com/pymc-devs/pymc3/pull/4709) and
1414
[#4720](https://github.com/pymc-devs/pymc3/pull/4720)).
1515
+ `plot_gp_dist` is now available at the package level: `pm.plot_gp_dist` ([see #4835](https://github.com/pymc-devs/pymc3/pull/4835)).
16+
+ The experimental JAX sampling was removed. It will be included in the upcoming `v4` release ([see #4866](https://github.com/pymc-devs/pymc3/pull/4866)).
1617

1718
## PyMC3 3.11.2 (14 March 2021)
1819

pymc3/sampling_jax.py

Lines changed: 0 additions & 225 deletions
This file was deleted.

pymc3/tests/test_sampling_jax.py

Lines changed: 0 additions & 19 deletions
This file was deleted.

scripts/check_all_tests_are_covered.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from pathlib import Path
1313

1414
if __name__ == "__main__":
15-
testing_workflows = ["jaxtests.yml", "pytest.yml"]
15+
testing_workflows = ["pytest.yml"]
1616
ignored = set()
1717
non_ignored = set()
1818
for wfyml in testing_workflows:

0 commit comments

Comments
 (0)