Skip to content

Tweaks to predict method of ModelBuilder #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drbenvincent opened this issue Oct 6, 2022 · 4 comments · Fixed by #90
Closed

Tweaks to predict method of ModelBuilder #88

drbenvincent opened this issue Oct 6, 2022 · 4 comments · Fixed by #90

Comments

@drbenvincent
Copy link

Remove point_estimate kwarg of the ModelBuilder.predict method. Instead have two distinct methods...

  • predict (which returns the full idata) and
  • predict_point which returns the point estimate.

Tagging @michaelosthege, @twiecki.
@twiecki
Copy link
Member

twiecki commented Oct 6, 2022

CC @shashank

@drbenvincent drbenvincent mentioned this issue Oct 11, 2022
Merged
@drbenvincent
Copy link
Author

Maybe even an additional predict_proba to fit in with sktime API https://www.sktime.org/en/stable/examples/01_forecasting.html?highlight=predict_proba#predict_proba---distribution-predictions

@twiecki
Copy link
Member

twiecki commented Oct 11, 2022

@drbenvincent yeah, I think that's a good idea.

@5hv5hvnk
Copy link
Member

Sorry for late response, I can probably remove the point estimate from the ModelBuilder and raise a PR of the same today itself.

@5hv5hvnk 5hv5hvnk mentioned this issue Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added predict_posterior 5hv5hvnk/pymcx
3 participants
@twiecki @drbenvincent @5hv5hvnk