Skip to content

pytest is checking the docstrings too when passed on windows #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5hv5hvnk opened this issue Sep 12, 2022 · 2 comments
Closed

pytest is checking the docstrings too when passed on windows #81

5hv5hvnk opened this issue Sep 12, 2022 · 2 comments

Comments

@5hv5hvnk
Copy link
Member

5hv5hvnk commented Sep 12, 2022 •
edited
Loading

I believe we should not pass --doctest-modules in here, because of this even the doc string from code is passed and throws errors.

https://github.com/pymc-devs/pymc-experimental/blob/14e24063a9da3a624dff2e5c84528dedf7e522fe/.github/workflows/test.yml#L134
@5hv5hvnk 5hv5hvnk mentioned this issue Sep 12, 2022
Merged
@ferrine
Copy link
Member

ferrine commented Sep 12, 2022

The CI is doing good job testing code samples in documentation

@5hv5hvnk
Copy link
Member Author

The same should be applied to line executing on ubuntu then, since it misses the parameter there.
https://github.com/pymc-devs/pymc-experimental/blob/14e24063a9da3a624dff2e5c84528dedf7e522fe/.github/workflows/test.yml#L71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ferrine @5hv5hvnk