Skip to content

fix test_random_draws flakiness #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelraczycki opened this issue Jun 10, 2023 · 1 comment · Fixed by #195
Closed

fix test_random_draws flakiness #192

michaelraczycki opened this issue Jun 10, 2023 · 1 comment · Fixed by #195
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@michaelraczycki
Copy link
Collaborator

michaelraczycki commented Jun 10, 2023 •
edited
Loading

https://github.com/pymc-devs/pymc-experimental/actions/runs/5228903518/jobs/9441547331?pr=191

Recent changes in pymc and logprob submodule has caused the test to become flaky. Probably the solution is to add random seed to the test.
@michaelraczycki michaelraczycki added bug Something isn't working good first issue Good for newcomers labels Jun 10, 2023
@ricardoV94
Copy link
Member

The changes are unrelated, the test is/should be as flaky as it was before

@pdb5627 pdb5627 mentioned this issue Jun 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added seeding to draws in tests pdb5627/pymc-experimental
2 participants
@ricardoV94 @michaelraczycki