renamed to _generate_and_preprocess_model_data (#232)

* renamed to _generate_and_preprocess_model_data

* including new naming in tests

* updating to 3.8 typehinting

Author: michaelraczycki

pymc_experimental/linearmodel.py

@@ -100,7 +100,7 @@ def _data_setter(self, X: pd.DataFrame, y: Optional[Union[pd.DataFrame, pd.Serie
             if y is not None:
                 pm.set_data({"y_data": y.squeeze()})
 
-    def generate_and_preprocess_model_data(
+    def _generate_and_preprocess_model_data(
         self, X: Union[pd.DataFrame, pd.Series], y: pd.Series
     ) -> None:
         """

pymc_experimental/model_builder.py

@@ -205,7 +205,7 @@ def _generate_and_preprocess_model_data(
         Examples
         --------
         >>>     @classmethod
-        >>>     def generate_and_preprocess_model_data(self, X, y):
+        >>>     def _generate_and_preprocess_model_data(self, X, y):
                     coords = {
                         'x_dim': X.dim_variable,
                     } #only include if applicable for your model
@@ -494,7 +494,7 @@ def fit(
         if y is None:
             y = np.zeros(X.shape[0])
         y = pd.DataFrame({self.output_var: y})
-        self.generate_and_preprocess_model_data(X, y.values.flatten())
+        self._generate_and_preprocess_model_data(X, y.values.flatten())
         self.build_model(self.X, self.y)
 
         sampler_config = self.sampler_config.copy()

pymc_experimental/tests/test_model_builder.py

@@ -16,7 +16,7 @@
 import json
 import sys
 import tempfile
-from typing import Dict
+from typing import Dict, Union
 
 import numpy as np
 import pandas as pd
@@ -122,6 +122,12 @@ def default_model_config(self) -> Dict:
             "obs_error": 2,
         }
 
+    def _generate_and_preprocess_model_data(
+        self, X: Union[pd.DataFrame, pd.Series], y: pd.Series
+    ) -> None:
+        self.X = X
+        self.y = y
+
     @property
     def default_sampler_config(self) -> Dict:
         return {