Skip to content

Commit 12e21de

Browse files
Remove dead code from kalman_filter.py (#393)
* Remove `SteadyStateFilder` Rename `CholeskyFilter` to `SquareRootFilter` to match the literature * Use square root filter equations in `SquareRootFilter` * Remove `SingleTimeSeriesFilter` * Remove tests referencing old code
1 parent 4deeec6 commit 12e21de

File tree

7 files changed

+163
-315
lines changed

7 files changed

+163
-315
lines changed

pymc_experimental/statespace/core/statespace.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@
1818

1919
from pymc_experimental.statespace.core.representation import PytensorRepresentation
2020
from pymc_experimental.statespace.filters import (
21-
CholeskyFilter,
2221
KalmanSmoother,
23-
SingleTimeseriesFilter,
22+
SquareRootFilter,
2423
StandardFilter,
25-
SteadyStateFilter,
2624
UnivariateFilter,
2725
)
2826
from pymc_experimental.statespace.filters.distributions import (
@@ -53,9 +51,7 @@
5351
FILTER_FACTORY = {
5452
"standard": StandardFilter,
5553
"univariate": UnivariateFilter,
56-
"steady_state": SteadyStateFilter,
57-
"single": SingleTimeseriesFilter,
58-
"cholesky": CholeskyFilter,
54+
"cholesky": SquareRootFilter,
5955
}
6056

6157

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,15 @@
11
from pymc_experimental.statespace.filters.distributions import LinearGaussianStateSpace
22
from pymc_experimental.statespace.filters.kalman_filter import (
3-
CholeskyFilter,
4-
SingleTimeseriesFilter,
3+
SquareRootFilter,
54
StandardFilter,
6-
SteadyStateFilter,
75
UnivariateFilter,
86
)
97
from pymc_experimental.statespace.filters.kalman_smoother import KalmanSmoother
108

119
__all__ = [
1210
"StandardFilter",
1311
"UnivariateFilter",
14-
"SteadyStateFilter",
1512
"KalmanSmoother",
16-
"SingleTimeseriesFilter",
17-
"CholeskyFilter",
13+
"SquareRootFilter",
1814
"LinearGaussianStateSpace",
1915
]

0 commit comments

Comments
 (0)