Skip to content

Update data container notebook to reflect changes to pm.Data #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jessegrabowski opened this issue May 3, 2024 · 1 comment · Fixed by #676
Closed

Update data container notebook to reflect changes to pm.Data #659

jessegrabowski opened this issue May 3, 2024 · 1 comment · Fixed by #676
Labels
good first issue Good for newcomers

Comments

@jessegrabowski
Copy link
Member

pymc-devs/pymc#7047 depreciates pm.ConstantData and pm.MutableData (again), so the data container notebook no longer reflects best practices. It should be updated to:

  1. Remove the explainer about the differences between MutableData and ConstantData, since it no longer exists, and;
  2. Use pm.Data everywhere in the applied examples
@fonnesbeck fonnesbeck added the good first issue Good for newcomers label Jun 15, 2024
@Dekermanjian
Copy link
Contributor

Hey, would it be alright if I worked on this?

@Dekermanjian Dekermanjian mentioned this issue Jul 28, 2024
Merged
@OriolAbril OriolAbril linked a pull request Aug 1, 2024 that will close this issue
updated data_container.ipynb to reflect changes to pm.Data containers in pymc v5.16 #676
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@fonnesbeck @Dekermanjian @jessegrabowski