Skip to content

Time variable in Lotka-Volterra plots #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PRKramer opened this issue Nov 1, 2023 · 4 comments
Closed

Time variable in Lotka-Volterra plots #588

PRKramer opened this issue Nov 1, 2023 · 4 comments
Assignees

Comments

@PRKramer
Copy link
Contributor

PRKramer commented Nov 1, 2023

Approximate Bayesian Computation:
Notebook url:

Issue description

Both plots of population versus time do not represent time correctly.

Note that this issue tracker is about the contents in the notebooks, if
the notebook is instead triggering a bug or error in pymc, please
report to https://github.com/pymc-devs/pymc/issues instead

Expected output

Time should be running from 0 to 15, not 0 to 100, based on how the variable t was defined.

Proposed solution

This can be simply fixed by including the t argument in the plot commands. For example in #plotting observed data

ax.plot(t,observed[:, 0], "x", label="prey")
ax.plot(t,observed[:, 1], "x", label="predator")

and similarly in #plot results

@OriolAbril
Copy link
Member

Thanks for reporting! Would you be interested in submitting a PR to fix it?

@PRKramer
Copy link
Contributor Author

PRKramer commented Nov 6, 2023

Yes, I'll await formal assignment.

@PRKramer
Copy link
Contributor Author

The notebook now has some overflow warnings and other errors being generated by the sampler. I don't think we tried to change anything other than the plots, so not sure how these problems arose?

@MacroLens
Copy link
Contributor

This issue can be closed.

@twiecki twiecki closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants