Skip to content

improve pre-commit checks when example notebooks are removed #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drbenvincent opened this issue Apr 9, 2022 · 1 comment
Open

Comments

@drbenvincent
Copy link
Contributor

drbenvincent commented Apr 9, 2022

When removing an example .ipynb file, the pre-commit checks do not check that the corresponding myst.md file has been deleted. Could add a check that there are no myst.md files without corresponding .ipynb files.

@OriolAbril
Copy link
Member

OriolAbril commented Apr 11, 2022

pre-commit check also seems to pass if there are myst without associated ipynb examples when again, it should fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants