Skip to content

Typo in GLM hierarchical binomial model #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farhanreynaldo opened this issue Nov 10, 2021 · 2 comments
Open

Typo in GLM hierarchical binomial model #247

farhanreynaldo opened this issue Nov 10, 2021 · 2 comments

Comments

@farhanreynaldo
Copy link
Contributor

farhanreynaldo commented Nov 10, 2021

Notebook title: GLM hierarchical binomial model
Notebook url: https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-hierarchical-binominal-model.ipynb

Issue description

I found several minor errors in the notebook, listed as follows:

  • In the notebook title and its filename, is the word binominal instead of binomial chosen by intention?
  • I found several typos in hierarchical in various spelling, namely heirarchical and heirarchichal.
  • There is inconsistency in PyMC3 spelling, which is pymc3.

And I would suggest suppressing the matplotlib code line (e.g. <AxesSubplot:xlabel='X', ylabel='Z'>) on figure output by putting the semicolon in the last line of code.

I would be happy to open a PR if any of the errors mentioned above are valid.

@OriolAbril
Copy link
Member

sounds great, can you also make sure it follows the style guide?

@farhanreynaldo
Copy link
Contributor Author

sounds great, can you also make sure it follows the style guide?

Sure, I will make the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants