Skip to content

Splines in PyMC #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Oct 3, 2021 · 4 comments
Closed

Splines in PyMC #234

OriolAbril opened this issue Oct 3, 2021 · 4 comments
Labels
extra dependencies Issues that require working with special dependencies tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

Notebook url: https://github.com/pymc-devs/pymc-examples/blob/main/examples/splines/spline.ipynb
reviewer: jhrcook

@OriolAbril OriolAbril added extra dependencies Issues that require working with special dependencies tracker id Issues used as trackers in the notebook update project, do not close! labels Oct 3, 2021
@OriolAbril
Copy link
Member Author

The notebook needs to be updated to follow the style guide. All notebooks must have a post directive in their first cell.

Ideally it would also use matplotlib directly instead of plotnine to reduce the dependencies on external libraries

@michaelosthege
Copy link
Member

The notebook should also mention the SplineWrapper and explain the difference to the spline built in the notebook.
https://github.com/pymc-devs/pymc/blob/073e26b9c650ff9ae851ab9904cb3ad9c905a643/pymc/distributions/dist_math.py#L316-L319

@OriolAbril
Copy link
Member Author

OriolAbril commented May 7, 2022

Updated by #274, moving it to v4 auto to signal there are still changes needed on the metadata. It is also being excluded from some of the pre-commit checks still, that needs to be fixed too before moving it to the "Done" column (by closing this issue)

See #274 (comment)

@kuvychko
Copy link
Contributor

Working on this notebook, as part of PyMC Open Source session #2 with @PrinceAsiedu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extra dependencies Issues that require working with special dependencies tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

3 participants