Skip to content

cox_model.ipynb doesn't have formatting run on it (double fmt: off) #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Jul 7, 2021 · 3 comments
Closed
Labels
good first issue Good for newcomers

Comments

@MarcoGorelli
Copy link
Contributor

Notebook title: cox_model.ipynb
Notebook url: https://github.com/pymc-devs/pymc-examples/blob/main/examples/survival_analysis/cox_model.ipynb

Issue description

Cell 4 starts with

# fmt: off

and ends with

#fmt: off

The latter should be

# fmt: on

Note that this issue tracker is about the contents in the notebooks, if
the notebook is instead triggering a bug or error in pymc3, please
report to https://github.com/pymc-devs/pymc3/issues instead

Expected output

If applicable, describe what should happen instead.

Proposed solution

If applicable, explain possible solutions and workarounds.

@MarcoGorelli MarcoGorelli added good first issue Good for newcomers tree: beginner Internal use label labels Jul 7, 2021
@OriolAbril
Copy link
Member

OriolAbril commented Jul 7, 2021

related to #127 (please tag both issues or only #127 in the PR)

EDIT: I have removed the beginner label because it should be only used in tracker issues to indicate that the notebook should be part of the begginer branch of the documentation tree. I described the tag as "internal use only" because users and new contributors should not care about those labels.

@OriolAbril OriolAbril removed the tree: beginner Internal use label label Jul 7, 2021
@MarcoGorelli
Copy link
Contributor Author

Ah, understood, thanks!

@MarcoGorelli
Copy link
Contributor Author

no longer necessary, as black's built-in notebook support runs cell-by-cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants