Skip to content

api quickstart #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Apr 5, 2021 · 4 comments
Closed

api quickstart #107

OriolAbril opened this issue Apr 5, 2021 · 4 comments
Labels
good first issue Good for newcomers high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

OriolAbril commented Apr 5, 2021

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/pymc3_howto/api_quickstart.ipynb
Reviewers:

The sections below may still be pending. If so, the issue is still available, it simply doesn't
have specific guidance yet. Please refer to this overview of updates

Known changes needed

Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.

General updates

  • Remove the ignore warnings
  • Add also an explanation on dims right below where shape is explained.
  • Look for places where add links to further reference pages. There are places where we could link to profiling notebook, to posteior predictive one... and help users navigate through the notebooks.

ArviZ related

  • I think we should include a note on model comparison with loo/waic and how converting to inferencedata by default computes and stores pointwise log likelihood values. If memory constrained or not aiming for model comparison, it can be disabled with idata_kwargs={"log_likelihood": True} in pm.sample call.
  • ArviZ usage is already good, but also some notes on the relation between projects, on the pm.plot_xyz aliases and some links to ArviZ would be nice

Notes

Exotic dependencies

None

Computing requirements

Models sample in <10 seconds

@OriolAbril OriolAbril added tracker id Issues used as trackers in the notebook update project, do not close! high impact Notebooks with most visits on docs.pymc.io good first issue Good for newcomers labels Apr 5, 2021
@farhanreynaldo
Copy link
Contributor

Hi , @OriolAbril. I would like to work on this issue, is it available for PR?

@OriolAbril
Copy link
Member Author

Hi, sorry for the late reply, it is available but being a high impact notebook, it will probably have timing constraints to update it along with our upcoming 4.beta version. This means we might ask for faster updates and changes and/or take over and finish the update ourselves. Let me know if this sounds ok or you'd prefer to work at your own pace on a different notebook

@farhanreynaldo
Copy link
Contributor

Hi, sorry for the late reply, it is available but being a high impact notebook, it will probably have timing constraints to update it along with our upcoming 4.beta version. This means we might ask for faster updates and changes and/or take over and finish the update ourselves. Let me know if this sounds ok or you'd prefer to work at your own pace on a different notebook

That's understandable, I think I would like to work on a different notebook at my own pace.

@cluhmann
Copy link
Member

cluhmann commented Jun 3, 2022

Closed by #364? Sorry I forgot to associate this issue in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

3 participants