Fix no-name-in-module when variable is same as module name (#8169) (#8226)

Co-authored-by: Pierre Sassoulas <[email protected]>
(cherry picked from commit f690448)

Co-authored-by: Dani Alcala <[email protected]>

Author: github-actions[bot]

doc/whatsnew/fragments/8148.bugfix

@@ -0,0 +1,4 @@
+Fix ``no-name-in-module`` false positive raised when a package defines a variable with the
+same name as one of its submodules.
+
+Closes #8148

pylint/checkers/variables.py

@@ -2933,7 +2933,7 @@ def _check_module_attrs(
                 break
             try:
                 module = next(module.getattr(name)[0].infer())
-                if module is astroid.Uninferable:
+                if not isinstance(module, nodes.Module):
                     return None
             except astroid.NotFoundError:
                 if module.name in self._ignored_modules:

tests/regrtest_data/pkg_mod_imports/__init__.py

@@ -0,0 +1,6 @@
+base = [
+    'Exchange',
+    'Precise',
+    'exchanges',
+    'decimal_to_precision',
+]

tests/regrtest_data/pkg_mod_imports/base/__init__.py

@@ -0,0 +1,2 @@
+class SomeError(Exception):
+    pass

tests/regrtest_data/pkg_mod_imports/base/errors.py

@@ -0,0 +1 @@
+from pkg_mod_imports.base.errors import SomeError

tests/regrtest_data/test_no_name_in_module.py

@@ -1293,6 +1293,15 @@ def test_output_no_header(self) -> None:
             args, expected_output=expected, unexpected_output=not_expected
         )
 
+    def test_no_name_in_module(self) -> None:
+        """Test that a package with both a variable name `base` and a module `base`
+        does not emit a no-name-in-module msg."""
+        module = join(HERE, "regrtest_data", "test_no_name_in_module.py")
+        unexpected = "No name 'errors' in module 'list' (no-name-in-module)"
+        self._test_output(
+            [module, "-E"], expected_output="", unexpected_output=unexpected
+        )
+
 
 class TestCallbackOptions:
     """Test for all callback options we support."""